Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Updated CI Workflow and Dependency Fixes #27

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

jlw387
Copy link
Collaborator

@jlw387 jlw387 commented Aug 23, 2024

Updated the contents of python-app.yml to match the CI used in the test repository. Specific changes include:

  • Setting the workflow to run for pushes and pull requests to 'development' (previously the only specified branch was 'main')
  • Adding build tests for multiple versions of Python (3.10, 3.11, and 3.12).
  • Adding a "branch name check" which ensures that nothing is merged to main other than 'development' and hotfix branches.

jlw387 added 2 commits August 22, 2024 21:15
Adjusted requirements.txt to allow for newer versions of NumPy, pandas, and tabulate. The strict version requirements were causing installation/build issues for Python 3.12.
Updated the contents of `python-app.yml` to match the CI used in the test repository. Specific changes include:
 - Setting the workflow to run for pushes and pull requests to 'development' (previously the only specified branch was 'main')
 - Adding build tests for multiple versions of Python (3.10, 3.11, and 3.12).
 - Adding a "branch name check" which ensures that nothing is merged to main other than 'development' and hotfix branches.
@jlw387
Copy link
Collaborator Author

jlw387 commented Aug 23, 2024

Now that I'm looking at the previous CI document, it may be worth separating out tests from the build as different jobs, so that it is clearer where the failure occurred. Regardless, I need to fix the dependency issue for 3.12 before I can merge this into development anyways, so I'll need to close this request.

@jlw387
Copy link
Collaborator Author

jlw387 commented Aug 23, 2024

Closing this pull request now; will create another request once the dependency fix has been merged into this branch.

@jlw387 jlw387 closed this Aug 23, 2024
Feature: Updating Dependencies for Python 3.12 Compatibility
@jlw387 jlw387 reopened this Aug 23, 2024
@jlw387
Copy link
Collaborator Author

jlw387 commented Aug 23, 2024

During testing, making changes to a branch after starting the pull request seemed to cause issues, but in this case I was able to re-open and use this pull request for the branch after merging the dependency fixes in. Status checks all passed, so I will merge these changes into development.

@jlw387 jlw387 merged commit 9ce1c2f into development Aug 23, 2024
6 checks passed
@jlw387 jlw387 changed the title Updated CI Workflow Feature: Updated CI Workflow and Dependency Fixes Aug 23, 2024
@jlw387
Copy link
Collaborator Author

jlw387 commented Aug 23, 2024

I have now renamed the pull request to make the changes clearer. Because the merge was successful, I will now delete the branches for the two features.

@jlw387 jlw387 deleted the feature_improved_CI branch August 23, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant