Implement Set Junior mode #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brought up today in community meeting as a popular game mode. Set Junior involves a 27 card deck. For security / database integrity reasons at scale, I'm taking a different approach than the one in #148, filtering out the cards from the deck post hoc. Set Junior has hints enabled. Looking through the code, there's no reason why other game modes can't have hints enabled either. I can flip this switch in the future if there's demand for it, will probably want to write a migration though to check integrity of previous setchain/ultraset games that had hints on in the database but are currently interpreted as "off" due to hints not being supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought up today in community meeting as a popular game mode. Set Junior involves a 27 card deck.
For security / database integrity reasons at scale, I'm taking a different approach than the one in #148, filtering out the cards from the deck post hoc.
Set Junior has hints enabled. Looking through the code, there's no reason why other game modes can't have hints enabled either. I can flip this switch in the future if there's demand for it, will probably want to write a migration though to check integrity of previous setchain/ultraset games that had hints on in the database but are currently interpreted as "off" due to hints not being supported.
Closes #148.