Bacnet 1.0.20 beta #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Analog Object raised an CHANG_OF_VALUE Event. This was wrong and now raises an CHANGE_OF_STATE Event
gralin
requested changes
Mar 21, 2018
There was a problem hiding this comment.
Thanks for the pull request. Please see my review comments. Also, please correct the title of pull request to something like: Update AnotherStorageImplementation to use BACnet 1.10.20-beta. If you have time you can also update other projects and include them in this pull request (then the title would be different)
| *.sln.iml | ||
| AnotherStorageImplementation/packages.config |
There was a problem hiding this comment.
why did you add packages.config to ignored?
| </Reference> | ||
| <Reference Include="SharpPcap, Version=4.4.0.0, Culture=neutral, processorArchitecture=MSIL"> | ||
| <HintPath>C:\Users\sschulze.PLUETH\source\repos\BACnetCommand\packages\SharpPcap.4.4.0\lib\SharpPcap.dll</HintPath> | ||
| </Reference> |
There was a problem hiding this comment.
hintpaths are invalid! use relative paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.