Prevent reading past the closing tag of a cov subscription

This was already fixed in YABE back in r265 https://sourceforge.net/p/yetanotherbacnetexplorer/code/265/tree//trunk/Yabe/BACnetBase.cs?diff=52d7f6223e5e832718335a6a:264
ela-compil · Apr 14, 2024 · 52c1209 · 52c1209
1 parent 96b580d
commit 52c1209
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/Serialize/ASN1.cs b/Serialize/ASN1.cs
@@ -2358,7 +2358,7 @@ public static int decode_cov_subscription(byte[] buffer, int offset, int apduLen
             return -1;
         len += decode_unsigned(buffer, offset + len, lenValueType, out value.TimeRemaining);
 
-        if (len < apduLen && IS_OPENING_TAG(buffer[offset + len]))
+        if (len < apduLen && !IS_CLOSING_TAG(buffer[offset + len]))
         {
             decode_tag_number_and_value(buffer, offset + len, out tagNumber, out lenValueType);
             if (tagNumber != 4)