Rust scheduler: Config specification and parsing #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherbel
commented
Sep 20, 2023
| } | ||
|
|
||
| #[derive(Deserialize)] | ||
| #[serde(tag = "type")] |
There was a problem hiding this comment.
This simplifies serialization in Python
SoloJacobs
requested changes
Sep 20, 2023
SoloJacobs
previously approved these changes
Sep 20, 2023
jherbel
force-pushed
the
dev/joerg/rust
branch
from
102cdfc to
0a65422
Compare
SoloJacobs
previously approved these changes
Sep 21, 2023
v2/rust/src/config.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn test_suites_sorted() { |
There was a problem hiding this comment.
Test name/documentation needs improving. Otherwise, the purpose of the test is unclear.
jherbel
force-pushed
the
dev/joerg/rust
branch
from
0a65422 to
8af73c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMK-14520