Rust scheduler: environment building #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMK-14557
SoloJacobs
reviewed
Sep 26, 2023
| suite_name, | ||
| &mut build_instructions.command, | ||
| ) | ||
| .context("Configuring stdio of environment build process failed")?; |
There was a problem hiding this comment.
OTI: Is this really correct? I think failing to build one environment should not affect the remaining tests. Better build everything, otherwise the user has to reconfigure till next error.
There was a problem hiding this comment.
I am not 100% sure about it either. However, if this happens, there is anyway a severe problem (we were unable to open files). So most likely, it doesn't matter if we crash here or later on, since nothing would run anyway. If this turns out to be a problem, we can change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMK-14557