Implement CommandSpec structure
#371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherbel
force-pushed
the
dev/joerg/main
branch
from
eed950b to
a66882e
Compare
SoloJacobs
reviewed
Oct 11, 2023
SoloJacobs
previously approved these changes
Oct 11, 2023
jherbel
force-pushed
the
dev/joerg/main
branch
from
a66882e to
2e68121
Compare
This struct will replace `std::process::Command` in various places to circumvent potential non-UTF-8 strings in the latter. Note that we explicitly do not implement the handling of environment variables for now. We currently have no need for this, since we anyway won't set `ROBOCORP_HOME` in the future. CMK-14766
jherbel
force-pushed
the
dev/joerg/main
branch
from
2e68121 to
f8b481f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This struct will replace
std::process::Commandin various places to circumvent potential non-UTF-8 strings in the latter.Note that we explicitly do not implement the handling of environment variables for now. We currently have no need for this, since we anyway won't set
ROBOCORP_HOMEin the future.CMK-14766