Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove TerminationFlag #440

Merged
merged 1 commit into from
Dec 4, 2023
Merged

remove TerminationFlag #440

merged 1 commit into from
Dec 4, 2023

Conversation

SoloJacobs
Copy link
Contributor

CMK-15137

jherbel
jherbel requested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@jherbel jherbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also change the names of the corresponding variables to cancellation_flag or cancellation_token or so. Otherwise, we have things such as termination_flag.is_cancelled() where the naming is inconsistent (termination and cancellation are mixed).

@SoloJacobs SoloJacobs force-pushed the dev/sol/spinloop branch 2 times, most recently from 98dc20a to 1bea359 Compare December 4, 2023 12:31
@SoloJacobs SoloJacobs requested a review from jherbel December 4, 2023 13:35
@SoloJacobs SoloJacobs merged commit ba6d550 into main Dec 4, 2023
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
@SoloJacobs SoloJacobs deleted the dev/sol/spinloop branch December 4, 2023 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jherbel jherbel jherbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SoloJacobs @jherbel