Avoid running all suites at the same time at scheduling start #449
+45
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherbel
force-pushed
the
dev/joerg/scheduling
branch
2 times, most recently
from
bf45ccf to
2a57121
Compare
jherbel
changed the title
This could lead to a high system load. Instead, we start as soon as the current timestamp is fully divisible by the execution interval.
jherbel
force-pushed
the
dev/joerg/scheduling
branch
from
2a57121 to
8992b00
Compare
SoloJacobs
reviewed
Dec 8, 2023
There was a problem hiding this comment.
Two general remarks about this change:
- It seems to me that calling
tick().awaitonclockhas a very similar effect. (at least ifInterval::now()is relatively similar in all suites when the clocks are started. - I think the change itself needs to clarify whether this is addressing a theoretical problem or whether there is something concrete, which we observed in practice.
| @@ -47,7 +58,7 @@ async fn run_suite_scheduler(suite: Suite) { | |||
| } | |||
|
|
|||
| async fn run_cleanup_job(cancellation_token: CancellationToken, suites: Vec<Suite>) { | |||
| let mut clock = interval(Duration::from_secs(300)); | |||
| let mut clock = interval_at(compute_start_time(300), Duration::from_secs(300)); | |||
There was a problem hiding this comment.
It seems to me that calling tick().await on clock has a very similiar effect.
There was a problem hiding this comment.
Not sure what you mean. If we dont use interval_at but interval, the first tick will complete immediately.
|
@SoloJacobs I discussed this with Simon, this a real problem (though not a severe one). See for example here: |
SoloJacobs
approved these changes
Dec 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could lead to a high system load. Instead, we start as soon as the current timestamp is fully divisible by the execution interval.