Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/sol/termination test i #452

Merged
merged 14 commits into from
Dec 13, 2023
Merged

Dev/sol/termination test i #452

merged 14 commits into from
Dec 13, 2023

Conversation

SoloJacobs
Copy link
Contributor

No description provided.

@SoloJacobs SoloJacobs force-pushed the dev/sol/termination_test_I branch from 591ca67 to 4794f1b Compare December 11, 2023 18:56
In order to write an integration test, the relevant functionality needs
to be part of the libary crate `robotmk`. The goal is to move
`run_attempts_until_succesful`.

This change moves `kill_process_tree`.

CMK-15433
In order to write an integration test, the relevant functionality needs
to be part of the libary crate `robotmk`. The goal is to move
`run_attempts_until_succesful`.

This change moves `scheduler/results.rs` to `results.rs`. It leaves
functionality which belongs to a dedicated `build` module in the
future.

CMK-15433
In order to write an integration test, the relevant functionality needs
to be part of the libary crate `robotmk`. The goal is to move
`run_attempts_until_succesful`.

This change moves `ResultCode`.

CMK-15433
@SoloJacobs SoloJacobs force-pushed the dev/sol/termination_test_I branch from 4794f1b to 5952a69 Compare December 12, 2023 18:30
@SoloJacobs SoloJacobs requested a review from jherbel December 12, 2023 19:32
v2/robotmk/src/suites.rs Outdated Show resolved Hide resolved
v2/robotmk/src/bin/scheduler/environment.rs Outdated Show resolved Hide resolved
v2/robotmk/src/results.rs Show resolved Hide resolved
v2/robotmk/src/bin/scheduler/internal_config.rs Outdated Show resolved Hide resolved
v2/robotmk/src/bin/scheduler/results.rs Show resolved Hide resolved
In order to write an integration test, the relevant functionality needs
to be part of the libary crate `robotmk`. The goal is to move
`run_attempts_until_succesful`.

This change moves the `command_spec` module.

CMK-15433
In order to write an integration test, the relevant functionality needs
to be part of the libary crate `robotmk`. The goal is to move
`run_attempts_until_succesful`.

This change moves the `child_process_supervisor` module.

CMK-15433
In order to write an integration test, the relevant functionality needs
to be part of the libary crate `robotmk`. The goal is to move
`run_attempts_until_succesful`.

With this change, `EnvironmentBuildStatesAdministrator` does not depend
on `Suite`.

CMK-15433
In order to write an integration test, the relevant functionality needs
to be part of the libary crate `robotmk`. The goal is to move
`run_attempts_until_succesful`.

With this change,
* Name `EnvironmentBuildStatesAdministrator` as `BuildStageReporter`
* Consolidate `builder` functionality into one module
* Rework `EnvironmentBuildStatus`
* Rework `EnvironmentBuildStatusError`

CMK-15433
In order to write an integration test, the relevant functionality needs
to be part of the libary crate `robotmk`. The goal is to move
`run_attempts_until_succesful`.

Create independent `build` module.

CMK-15433
In order to write an integration test, the relevant functionality needs
to be part of the libary crate `robotmk`. The goal is to move
`run_attempts_until_succesful`.

This change moves `Environment`.

CMK-15433
In order to write an integration test, the relevant functionality needs
to be part of the libary crate `robotmk`. The goal is to move
`run_attempts_until_succesful`.

This change moves `rf.rs` to `rf/mod.rs`, etc. This makes moving
directories easier.

CMK-15433
In order to write an integration test, the relevant functionality needs
to be part of the libary crate `robotmk`. The goal is to move
`run_attempts_until_succesful`.

This change moves the `rf` and `sessions` module.

CMK-15433
In order to write an integration test, the relevant functionality needs
to be part of the libary crate `robotmk`. The goal is to move
`run_attempts_until_succesful`.

With this change, `run_attempts_until_succesful` does not depend on
`internal_config`.

CMK-15433
In order to write an integration test, the relevant functionality needs
to be part of the libary crate `robotmk`. The goal is to move
`run_attempts_until_succesful`.

With this change, `run_attempts_until_succesful` is moved to the
library crate `robotmk`.

CMK-15433
@SoloJacobs SoloJacobs force-pushed the dev/sol/termination_test_I branch from 5952a69 to e244453 Compare December 13, 2023 12:10
@SoloJacobs SoloJacobs merged commit afd584a into main Dec 13, 2023
20 checks passed
@SoloJacobs SoloJacobs deleted the dev/sol/termination_test_I branch December 13, 2023 12:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants