Dev/sol/hololib #634
Merged
Dev/sol/hololib #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherbel
requested changes
Nov 8, 2024
|
Once we are finished here, we will re-visit our internal datastructures. It seems that we need something like in multiple places. So it makes sense to at least consider an adjustment here, something |
SoloJacobs
force-pushed
the
dev/sol/hololib
branch
2 times, most recently
from
75bd0f7 to
1486868
Compare
jherbel
approved these changes
Nov 11, 2024
jherbel
force-pushed
the
dev/sol/hololib
branch
from
1486868 to
4c3314c
Compare
|
As discussed: We will merge this to have the functionality in place. In a follow-up step, we will investigate options to re-work our setup steps. The current data structures are well-suited for environment building and plan scheduling (per-plan operations), but they make for example per-session operations cumbersome. |
CMK-19970
This change sets the ROBOCORP_HOME environment variable during: * setup (various rcc configuration calls, * build (rcc task script), * while executing tests. For the `rcc configuration longpaths --enable` step this is not strictly necessary, but done for consistency anyway. CMK-19971
Previously, the scheduler assumed that sufficient permissions where already available for users to run their tests. The base directory and its subdirectories are now created during setup with sufficient permissions for Windows. CMK-19971
Let's you know which variable is missing CMK-20046
CMK-20046
...robocorp homes. We might need add a `bazel` cache. CMK-19971
If a directory belongs to a user, then he may change the permissions of that directory. If a new directory is created, it will always belong to the user, that created it. This change affects use cases, where a robocorp_home_base was configured, which already exists (on Windows). We don't want the user (which owned the robocorp_home_base before the scheduler is started) to be able to modify permissions on newly created `ROBOCORP_HOME` directories. However, this change cannot protect against already existing directories, which have malicious code inside them (or gave full access to a different user). CMK-19971
SoloJacobs
force-pushed
the
dev/sol/hololib
branch
from
4c3314c to
82f348c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.