Small improvements #645
Merged
Small improvements #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherbel
force-pushed
the
dev/joerg/misc
branch
2 times, most recently
from
7a5d42c to
41f50b5
Compare
SoloJacobs
reviewed
Nov 20, 2024
`Terminate` is more expressive and than `anyhow::Error`, since it explicitly takes cancellation into account.
* Log `tokio::task::JoinError`s (hopefully they never occur). * Return right away when receiving `Terminate::Cancelled` in task that runs group of sequential plans.
jherbel
force-pushed
the
dev/joerg/misc
branch
from
41f50b5 to
b57b280
Compare
SoloJacobs
approved these changes
Nov 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.