Scheduler main: Check for cancellation between base setup and setup steps #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherbel
force-pushed
the
dev/joerg/check_cancellation_between_base_setup_and_steps
branch
from
acb14b8 to
370323c
Compare
SoloJacobs
reviewed
Nov 26, 2024
SoloJacobs
requested changes
Nov 26, 2024
Return `Terminate::Cancelled` and the actual main function do the rest.
…teps Barely makes a difference but is the correct thing to do.
jherbel
force-pushed
the
dev/joerg/check_cancellation_between_base_setup_and_steps
branch
from
370323c to
dd605c5
Compare
SoloJacobs
approved these changes
Nov 27, 2024
jherbel
deleted the
dev/joerg/check_cancellation_between_base_setup_and_steps
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Barely makes a difference but is the correct thing to do.