Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement option to configure secret environment variables for RF executions #654

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Implement option to configure secret environment variables for RF executions #654

merged 4 commits into from
Dec 2, 2024

Conversation

jherbel
Copy link
Contributor

@jherbel jherbel commented Nov 25, 2024

No description provided.

@jherbel jherbel force-pushed the dev/joerg/CMK-19115_rf_params_secret_env branch 3 times, most recently from 7c0d855 to ab68668 Compare November 25, 2024 10:26
@jherbel jherbel requested a review from SoloJacobs November 25, 2024 10:37
SoloJacobs
SoloJacobs requested changes Nov 26, 2024
View reviewed changes
src/command_spec.rs Show resolved Hide resolved
src/command_spec.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
@SoloJacobs SoloJacobs self-requested a review November 27, 2024 08:58
SoloJacobs
SoloJacobs reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@SoloJacobs SoloJacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think, I can't review this change.

@jherbel
CommandSpec: Rename envs --> envs_rendered_obfuscated
0645a6a 
We will in a subsequent change add a new field specifically for environment
variables that are not obfuscated when rendering (eg. for logging purposes).

CMK-19115
@jherbel
Make CommandSpec.add_obfuscated_env a bit more comfortable to use
33203a8
@jherbel
CommandSpec: Implement field for non-obfuscated environment variables
7d2c0fd 
CMK-19115
@jherbel
Implement option to configure secret environment variables for RF exe…
5f4e7f5 
…cutions

Specific use case: CryptoLibrary for encrypting login data. 

CMK-19115
@jherbel jherbel force-pushed the dev/joerg/CMK-19115_rf_params_secret_env branch from ab68668 to 5f4e7f5 Compare December 2, 2024 13:53
@jherbel jherbel requested a review from SoloJacobs December 2, 2024 13:58
@jherbel jherbel merged commit 7a025a5 into main Dec 2, 2024
23 checks passed
@jherbel jherbel deleted the dev/joerg/CMK-19115_rf_params_secret_env branch December 2, 2024 16:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SoloJacobs SoloJacobs SoloJacobs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jherbel @SoloJacobs