Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset RCC binary and profile permissions during setup #655

Closed
wants to merge 1 commit into from

Conversation

jherbel
Copy link
Contributor

@jherbel jherbel commented Nov 26, 2024

Since explicitly grant plan users access to these files, we should also reset the access to cover the case where a plan user is removed or changes.

Since explicitly grant plan users access to these files, we should also reset
the access to cover the case where a plan user is removed or changes.
Copy link
Contributor

@SoloJacobs SoloJacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how a user having read/execute permissions for RCC is an issue? Any user with an internet connection could execute such a file, no? Or am I missing something Windows specific?

@jherbel
Copy link
Contributor Author

jherbel commented Nov 26, 2024

It is not really an issue, but since we explicitly grant these permissions, we should also remove them I would say.

@SoloJacobs
Copy link
Contributor

Hmm, but it does not seem correct to me to skip the rcc plans in case the fails, since this step does not seem necessary. Having unecessary steps is a little odd.

@jherbel
Copy link
Contributor Author

jherbel commented Nov 27, 2024

We decided to approach this differently: Instead of granting access to specific users, we will grant access to the Users group. This way, we won't have to deal with resetting permissions.

@jherbel jherbel closed this Nov 27, 2024
@jherbel jherbel deleted the dev/joerg/reset_rcc_file_permissions branch November 27, 2024 13:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants