Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0.1 #1126

Merged
merged 2 commits into from
Dec 27, 2024
Merged

v3.0.1 #1126

merged 2 commits into from
Dec 27, 2024

Conversation

elalish
Copy link
Owner

@elalish elalish commented Dec 26, 2024

Bindings

Bug Fixes

Performance Improvements

Build/CI Updates

Tests

Documentation

New Contributors

@pca006132
Copy link
Collaborator

Maybe wait for #1125, it can be serious. I will do it tmr.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (b7a0275) to head (c469ce8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1126   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files          30       30           
  Lines        5915     5915           
=======================================
  Hits         5417     5417           
  Misses        498      498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elalish elalish merged commit 98b8142 into master Dec 27, 2024
28 checks passed
@elalish elalish deleted the v3.0.1 branch December 27, 2024 20:03
@elalish
Copy link
Owner Author

elalish commented Dec 27, 2024

@pca006132 The wheels all built, but the SDist failed because it can't find ninja apparently: https://github.com/elalish/manifold/actions/runs/12520191318

It also has a warning about how to specify the cmake version - not sure if that's part of it. Seems unlikely that it really is missing something so fundamental if it worked before. At least npm worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants