Highlight matches in main search results #1065
Comments
12 tasks
|
As for highlighting keep in mind we probably won't be able to do this when searching slides and transcripts unless we use a timeline representation. This probably requires a clear distinction of "search in DC metadata" vs. "search in video (slides/transcripts)". |
|
Yeah, somehow indicating that a match was found in slides/transcripts must work a bit differently than matches in text metadata, true. |
7 tasks
owi92
added a commit
that referenced
this issue
Nov 18, 2024
This PR improves the whole main search page in various ways. Most important points: - Thumbnails are now on the left (I know a certain someone who will very much welcome this change 😉 ) - The three different kinds of results were designed to be visually easier to distinguish. - Videos and series also show the realm path (if there is only one host realm) - The date is added to videos - The matching portion in search results is highlighted, to show the user immediately why a result appears. - Note: This does not work for "creators" yet, due to a limitation in the search index we use. We have to wait for an upstream fix. - Note: metadata like description and title are truncated if too long. If the match would appear in the parts that are cut off, it would be still confusing for the user. Therefore, the metadata is truncated/cut in such a way that the part with the match is shown. (Example: first result for search "hadron myers") This PR is a draft because I still want to do this: - [x] Talk to our designer - [x] Squash two mobile keyboard bugs - [x] ~~Potentially change the "realm" icon~~ -> No - [x] Fix bug where the last input on the search field can sometimes be ignored - [x] ~~Make highlight color stronger~~ -> See some comments below In a separate, follow-up PR I still plan on doing these search-related things: - Use Meili federated search (improves ranking, potentially speed, and prepares pagination) - Improve ranking to make series appear before videos of that series with title = series title when searching for series title - Potentially merge series and page results when the page is a "series-only-page" for that series - Maybe: with multiple host realms, if only one exists that derives its name from the series/event, use it for breadcrumbs & link. - Finally decide about #500 Finally, filtering is still missing, which deserves a PR on its own. --- Feedback is very welcome! Fixes #470 Fixes #1066 Fixes #1065
|
Done in #1273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When searching for "Peter", then that part of the presenter should be highlighted in the search results. Same for all other metadata fields of course. The style should make sure people can easily see the matches at a glance, but without being super ugly or burning one's eyes.
There are some challenges here since (a) most metadata can be truncated and (b) in the future, some metadata will only be shown if there is a match. So the match influences what metadata is shown and how to truncate metadata. For example, if there is a match at the end of the description, that part should be shown with some context around it. And not just the start of the description. This also briefly came up here.
The text was updated successfully, but these errors were encountered: