Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all][settings.rb] feat: proposal for sequel based Settings; #591

Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from
Draft

[all][settings.rb] feat: proposal for sequel based Settings; #591

wants to merge 1 commit into from

Conversation

ondreian
Copy link
Contributor

No description provided.

@OSXLich-Doug
Copy link
Contributor

@ondreian - Regret that I stomped on this on the breakout branch. Just FYI - I pulled your method SettingsNew and pasted over the method Settings that is currently live. Also had to bring in the deprecated calls, particularly Settings.load because yes - seems every script calls it.

But this works. It just works. Of course. I'll keep playtesting it, but I think this is solid at this point.

@mrhoribu mrhoribu changed the title feat: proposal for sequel based Settings; [all][settings.rb] feat: proposal for sequel based Settings; Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ondreian @OSXLich-Doug