[all][games.rb] bugfix: correct $_SERVERSTRING_ prior to FE #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only corrected `$_SERVERSTRING_` for bad XML after it was sent to the FE for situations of nested single quotes or nested double quotes. This PR corrects this so that it's properly escaped prior to sending to FE.
MahtraDR
reviewed
Nov 16, 2024
merge staging into branch
|
No issues from me so far. But would like confirmation from others no issue either before merging. |
MahtraDR
added a commit
to MahtraDR/lich-5
that referenced
this pull request
Dec 12, 2024
For comparison against elanthia-online#698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only corrected
$_SERVERSTRING_for bad XML after it was sent to the FE for situations of nested single quotes or nested double quotes. This PR corrects this so that it's properly escaped prior to sending to FE.