Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrap 'fs.realpath.native' when configured with asyncHooks=false #2403

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

trentm
Copy link
Member

@trentm trentm commented Oct 28, 2021

Before this fs.realpath.native would be undefined after wrapping
of fs.realpath.

Fixes: #2401

Checklist

  • Implement code
  • Add tests
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

Before this `fs.realpath.native` would be undefined after wrapping
of `fs.realpath`.

Fixes: #2401
@trentm trentm requested a review from astorm October 28, 2021 22:20
@trentm trentm self-assigned this Oct 28, 2021
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Oct 28, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Oct 28, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-28T22:29:25.675+0000

  • Duration: 18 min 41 sec

  • Commit: fd4b8a1

Test stats 🧪

Test Results
Failed 0
Passed 22
Skipped 0
Total 22

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

Copy link
Contributor

@astorm astorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 approving -- it might worth reporting upstream to https://github.com/othiym23/async-listener

@trentm
Copy link
Member Author

trentm commented Oct 29, 2021

it might worth reporting upstream to https://github.com/othiym23/async-listener

Good idea. Done at othiym23/async-listener#143

@trentm trentm merged commit 9084f08 into master Oct 29, 2021
@trentm trentm deleted the trentm/fs-extra-boom branch October 29, 2021 16:00
astorm pushed a commit that referenced this pull request Oct 30, 2021
…2403)

Before this `fs.realpath.native` would be undefined after wrapping
of `fs.realpath`.

Fixes: #2401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throws when fs-extra@10 is imported with async hooks disabled
3 participants