apmsoak: log parsed config #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sensitive values are partially redacted to help with debugging without disclosing full information.
1pkg
previously approved these changes
Oct 4, 2024
kruskall
reviewed
Oct 4, 2024
internal/soaktest/runner.go
Outdated
| e.AddString("scenario", r.Scenario) | ||
| e.AddString("scenarios_path", r.ScenariosPath) | ||
| e.AddString("server_url", r.ServerURL) | ||
| e.AddString("secret_token", r.SecretToken) |
There was a problem hiding this comment.
issue: we might want to redact the secret token too
There was a problem hiding this comment.
Thanks for catching it! Fixed in dadce87
1pkg
previously approved these changes
Nov 4, 2024
1pkg
reviewed
Nov 4, 2024
internal/soaktest/runner.go
Outdated
| // It handles empty string by returning a fixed value: EMPTY. | ||
| func redact(v string) string { | ||
| redacted := "EMPTY" | ||
| if v != "" { |
There was a problem hiding this comment.
nit: should also check for len(v) > 4
There was a problem hiding this comment.
Good catch, I updated the check dbfd6c2. If the passed string is smaller than 4 characters the function would still return EMPTY, and I think it's acceptable because we don't expect any secret to be smaller than that.
1pkg
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print parsed configs in debug logs to help with debugging misbehaviours.
Sensitive values are partially redacted to help with debugging without
disclosing full information.