Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace go-multierror with native std go errors #13368

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Jun 8, 2024

Motivation/summary

Go 1.20 added errors.Join allowing for multierrors. Replace go-multierror usage with native go errors and drop the extra dependency on github.com/hashicorp/go-multierror

Can be dropped completely once elastic/beats#39837 is merged and beats is bumped

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Go 1.20 added errors.Join allowing for multierrors.
Replace go-multierror usage with native go errors and drop the extra
dependency on github.com/hashicorp/go-multierror
@kruskall kruskall requested a review from a team as a code owner June 8, 2024 21:32
Copy link
Contributor

mergify bot commented Jun 8, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jun 8, 2024
@kruskall kruskall merged commit fe28546 into elastic:main Jun 10, 2024
10 checks passed
@kruskall kruskall deleted the refactor/drop-go-multierror branch June 10, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants