Skip to content

Commit

Permalink
Remove module and metricset keys
Browse files Browse the repository at this point in the history
For the `/inputs/` API, `input` is they key used to identify the type of "input" running.
The `module` and `metricset` keys become redundant with the addition of `input`.
I don't know of anything that relies on those fields.
  • Loading branch information
andrewkroh committed Oct 26, 2023
1 parent 60f4af5 commit 526af95
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions metricbeat/mb/builders.go
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,6 @@ func newBaseMetricSets(r *Register, m Module) ([]BaseMetricSet, error) {
}
msID := id.String()
metrics := monitoring.NewRegistry()
monitoring.NewString(metrics, "module").Set(m.Name())
monitoring.NewString(metrics, "metricset").Set(name)
monitoring.NewString(metrics, "input").Set(m.Name() + "/" + name)
if host != "" {
monitoring.NewString(metrics, "host").Set(host)
Expand Down

0 comments on commit 526af95

Please sign in to comment.