Address review comments

elastic · Sep 22, 2023 · 8462128 · 8462128
1 parent 4eefdd9
commit 8462128
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/x-pack/metricbeat/module/azure/app_insights/data.go b/x-pack/metricbeat/module/azure/app_insights/data.go
@@ -190,7 +190,6 @@ func groupMetricsByDimension(metrics []MetricValue) map[string][]MetricValue {
 		helper               func(metrics []MetricValue)
 	)
 
-	// Review comment: Can you add some more comments to this helper func?
 	helper = func(metrics []MetricValue) {
 		for _, metric := range metrics {
 			dimensionKey := getSortedKeys(metric.SegmentName)

diff --git a/x-pack/metricbeat/module/azure/app_insights/data_test.go b/x-pack/metricbeat/module/azure/app_insights/data_test.go
@@ -48,7 +48,7 @@ func newMetricsTest(ts ...*date.Time) []MetricValue {
 		},
 	}
 
-	mv := make([]MetricValue, 0, 3)
+	mv := make([]MetricValue, 0, numOfMetricValue)
 	for i := range vals {
 		mv = append(mv,
 			MetricValue{