Added support for couchdb v3. #26950

StephanU · 2021-07-19T10:46:55Z

What does this PR do?

Added Metricbeat support for CouchDB version 3. It seems like the result format of the couchdb stats endpoints did not change from version 2 to 3 (the release notes do not mentioned changes to the stats endpoints).
So I'm just reusing the stats format of version 2.

Why is it important?

Added support for the lastest major CouchDB version 3.

Checklist

[x ] My code follows the style guidelines of this project
[x ] I have commented my code, particularly in hard-to-understand areas
~~[ ] I have made corresponding changes to the documentation~~
~~[ ] I have made corresponding change to the default configuration files~~
~~[ ] I have added tests that prove my fix is effective or that my feature works~~
[ x] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Install CouchDB version 3.x (https://couchdb.apache.org/)
Configure the CouchDB module for Metricbeat. (https://www.elastic.co/guide/en/beats/metricbeat/current/metricbeat-module-couchdb.html)
Check that the Kibana dashboard "[Metricbeat CouchDB] Database Overview" is filled with data.

Related issues

Closes Support for couchdb 3 #22743

elasticmachine · 2021-07-19T10:50:46Z

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-10-18T12:37:52.524+0000
Duration: 5 min 49 sec

Steps errors

Expand to view the steps failures

`Load a resource file from a library`

Took 0 min 0 sec . View more details here
Description: approval-list/elastic/beats.yml

`Error signal`

Took 0 min 0 sec . View more details here
Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/StephanU return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/StephanU : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/StephanU : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/orgs/members#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

StephanU · 2021-07-19T10:53:24Z

I am not allowed to add labels to the PR.

ChrsMark · 2021-07-26T08:34:34Z

cc: @sayden

elasticmachine · 2021-07-26T08:34:51Z

Pinging @elastic/integrations (Team:Integrations)

mergify · 2021-08-03T09:08:11Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b master upstream/master
git merge upstream/master
git push upstream master

…c-master

mergify · 2021-08-11T18:51:05Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b master upstream/master
git merge upstream/master
git push upstream master

mergify · 2021-08-19T05:05:33Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b master upstream/master
git merge upstream/master
git push upstream master

sayden

Hi @StephanU 🙂 Thanks for contributing with this. Please, can you create a V3.go instead of the current implementation? The idea is to make it explicit even on the filesystem instead of "implicit" (hidden) in a switch case.

Redis and MySQL modules also have the ability to test multiple versions of the same product using docker compose. Do you think you can take a quick look to add the same functionality here, please? 🙂

metricbeat/module/couchdb/server/server.go

StephanU · 2021-09-07T07:29:01Z

I added support for testing multiple versions of CouchDB. I tested the startup of the docker images by calling export COUCHDB_VERSION=<version> && docker-compose -up.
Calling export MODULE=couchdb && mage test runs successfully but it seems as if it does not test all configured versions but only one. How can I run tests for all configured versions?

mergify · 2021-09-07T21:54:32Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b master upstream/master
git merge upstream/master
git push upstream master

mergify · 2021-09-13T16:54:48Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b master upstream/master
git merge upstream/master
git push upstream master

mergify · 2021-09-22T12:55:13Z

This pull request does not have a backport label. Could you fix it @StephanU? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

belimawr · 2022-12-21T11:30:15Z

@belimawr @sayden Can you please take a fresh look at this PR to see what needs done. Support for couchdb v3 is a show stopper for my company. And thanks @StephanU for your presistence.

I'll try to get someone with knowledge about couchdb to look at it.

belimawr · 2022-12-21T11:32:25Z

@elastic/obs-service-integrations could some look at this PR?

sayden · 2023-03-24T07:43:43Z

If the output format is exactly the same than in CouchbDB v2 (it seems it is) and the dashboards are still working (it will be nice to see a screenshot of the dashboard attached to the PR as reference), this PR is good to go without any more changes.

StephanU · 2023-03-24T09:18:07Z

I'm running Kibana 7.13.2 (including my changes) and CouchDB 3.3.1

sayden

LGTM

sayden · 2023-03-30T10:37:56Z

@bturquet can your re-route this to the appropriate team to merge, please? I think it is ready to merge 🙂

mergify · 2023-10-09T09:07:57Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b master upstream/master
git merge upstream/main
git push upstream master

mergify · 2023-11-12T21:24:41Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b master upstream/master
git merge upstream/main
git push upstream master

elasticmachine · 2023-11-17T12:46:37Z

❕ Build Aborted

Either there was a build timeout or someone aborted the build.

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Duration: 5 min 33 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

mergify · 2024-04-15T09:13:57Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b master upstream/master
git merge upstream/main
git push upstream master

StephanU · 2024-07-25T10:10:43Z

Happy belated 3rd birthday. ;)

harnish-elastic

LGTM

Added support for couchdb v3.

50a1b59

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 19, 2021

Added pr id.

639a2f1

ChrsMark added the Team:Integrations Label for the Integrations team label Jul 26, 2021

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 26, 2021

StephanU added 2 commits August 3, 2021 11:29

Merge branch 'master' of https://github.com/elastic/beats into elasti…

3c1f9b8

…c-master

Merge branch 'elastic-master'

1817b4c

sayden self-requested a review August 5, 2021 14:49

Merge branch 'master' into master

8d2df59

sayden reviewed Aug 19, 2021

View reviewed changes

metricbeat/module/couchdb/server/server.go Outdated Show resolved Hide resolved

StephanU and others added 4 commits September 6, 2021 21:37

Merge branch 'master' into master

6a9d565

Created separate struct for version 3.

602ad1a

Use new V3 struct.

ddc13a1

Added support for testing multiple versions of couchdb.

527985b

StephanU requested a review from sayden September 7, 2021 07:29

Merge branch 'master' into master

8d7a355

mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 22, 2021

sayden added backport-skip Skip notification from the automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Sep 23, 2021

StephanU added 4 commits December 28, 2022 04:30

Merge branch 'main' into master

ae7c2bc

Merge branch 'main' into master

2d85487

Merge branch 'main' into master

bc75520

Merge branch 'main' into master

47d8956

Merge branch 'main' into master

670e761

sayden approved these changes Mar 30, 2023

View reviewed changes

StephanU added 2 commits May 4, 2023 16:10

Merge branch 'main' into master

c2f30e7

Merge branch 'main' into master

1fb424e

StephanU requested a review from a team as a code owner June 5, 2023 09:22

StephanU added 2 commits June 22, 2023 13:17

Merge branch 'main' into master

09960e2

Merge branch 'main' into master

64d48e4

StephanU added 2 commits October 10, 2023 11:29

Merge branch 'main' into master

b2288de

Merge branch 'main' into master

e32b127

Merge branch 'main' into master

11999ee

Merge branch 'main' into master

77e2a58

StephanU added 2 commits July 3, 2024 08:48

Merge branch 'main' into master

2054d10

Merge branch 'main' into master

594a345

harnish-elastic approved these changes Jul 26, 2024

View reviewed changes

kush-elastic and others added 2 commits July 26, 2024 11:10

Merge branch 'main' into master

6c8321b

Merge branch 'main' into master

826d959

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for couchdb v3. #26950

Added support for couchdb v3. #26950

StephanU commented Jul 19, 2021 •

edited

Loading

elasticmachine commented Jul 19, 2021 •

edited by jenkins-beats-ci bot

Loading

Build stats

`Load a resource file from a library`

`Error signal`

StephanU commented Jul 19, 2021

ChrsMark commented Jul 26, 2021

elasticmachine commented Jul 26, 2021

mergify bot commented Aug 3, 2021

mergify bot commented Aug 11, 2021

mergify bot commented Aug 19, 2021

sayden left a comment

StephanU commented Sep 7, 2021

mergify bot commented Sep 7, 2021

mergify bot commented Sep 13, 2021

mergify bot commented Sep 22, 2021

belimawr commented Dec 21, 2022

belimawr commented Dec 21, 2022

sayden commented Mar 24, 2023

StephanU commented Mar 24, 2023 •

edited

Loading

sayden left a comment

sayden commented Mar 30, 2023

mergify bot commented Oct 9, 2023

mergify bot commented Nov 12, 2023

elasticmachine commented Nov 17, 2023 •

edited

Loading

Build stats

mergify bot commented Apr 15, 2024

StephanU commented Jul 25, 2024

harnish-elastic left a comment

Added support for couchdb v3. #26950

Are you sure you want to change the base?

Added support for couchdb v3. #26950

Conversation

StephanU commented Jul 19, 2021 • edited Loading

What does this PR do?

Why is it important?

Checklist

How to test this PR locally

Related issues

elasticmachine commented Jul 19, 2021 • edited by jenkins-beats-ci bot Loading

❕ Build Aborted

Build stats

Steps errors

Load a resource file from a library

Error signal

🤖 GitHub comments

StephanU commented Jul 19, 2021

ChrsMark commented Jul 26, 2021

elasticmachine commented Jul 26, 2021

mergify bot commented Aug 3, 2021

mergify bot commented Aug 11, 2021

mergify bot commented Aug 19, 2021

sayden left a comment

Choose a reason for hiding this comment

StephanU commented Sep 7, 2021

mergify bot commented Sep 7, 2021

mergify bot commented Sep 13, 2021

mergify bot commented Sep 22, 2021

belimawr commented Dec 21, 2022

belimawr commented Dec 21, 2022

sayden commented Mar 24, 2023

StephanU commented Mar 24, 2023 • edited Loading

sayden left a comment

Choose a reason for hiding this comment

sayden commented Mar 30, 2023

mergify bot commented Oct 9, 2023

mergify bot commented Nov 12, 2023

elasticmachine commented Nov 17, 2023 • edited Loading

❕ Build Aborted

Build stats

🤖 GitHub comments

mergify bot commented Apr 15, 2024

StephanU commented Jul 25, 2024

harnish-elastic left a comment

Choose a reason for hiding this comment

StephanU commented Jul 19, 2021 •

edited

Loading

elasticmachine commented Jul 19, 2021 •

edited by jenkins-beats-ci bot

Loading

`Load a resource file from a library`

`Error signal`

StephanU commented Mar 24, 2023 •

edited

Loading

elasticmachine commented Nov 17, 2023 •

edited

Loading