Fix Stringer implementation of fingerprint processor #36468

zipperle · 2023-08-30T20:25:14Z

Proposed commit message

Fix Stringer implementation of fingerprint processor.
It incorrectly included a function reference in a json.Marshal call.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

[ ]

How to test this PR locally

Related issues

Closes The fingerprint processor incorrectly includes a function reference in a json.Marshal call #35174

Use cases

Screenshots

Logs

mergify · 2023-08-30T20:25:51Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @zipperle? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

elasticmachine · 2023-08-30T20:30:20Z

❕ Build Aborted

Expand to view the summary

Build stats

Start Time: 2023-11-14T06:41:44.293+0000
Duration: 5 min 33 sec

Steps errors

Expand to view the steps failures

`Load a resource file from a library`

Took 0 min 0 sec . View more details here
Description: approval-list/elastic/beats.yml

`Error signal`

Took 0 min 0 sec . View more details here
Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/zipperle return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/zipperle : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/zipperle : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/orgs/members#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

mergify · 2023-09-07T03:43:22Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b main upstream/main
git merge upstream/main
git push upstream main

cmacknz · 2023-09-08T19:45:35Z

/test

mergify · 2023-09-22T20:49:04Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b main upstream/main
git merge upstream/main
git push upstream main

mergify · 2023-10-02T10:37:05Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b main upstream/main
git merge upstream/main
git push upstream main

cmacknz · 2023-10-16T18:12:44Z

/test

pierrehilbert · 2023-10-25T12:09:11Z

Hello @zipperle,
Could you please fix the linter issue?

mergify · 2023-11-05T10:02:19Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @zipperle? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

zipperle · 2023-11-05T10:41:15Z

Hi @pierrehilbert, sure, I fixed the linter issues.

pierrehilbert · 2023-11-08T13:11:30Z

/test

elasticmachine · 2023-11-16T21:14:32Z

❕ Build Aborted

Expand to view the summary

Build stats

Start Time: 2023-11-16T21:09:38.214+0000
Duration: 5 min 48 sec

Steps errors

Expand to view the steps failures

`Load a resource file from a library`

Took 0 min 0 sec . View more details here
Description: approval-list/elastic/beats.yml

`Error signal`

Took 0 min 0 sec . View more details here
Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/zipperle return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/zipperle : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/zipperle : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/orgs/members#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-12-18T12:53:32Z

❕ Build Aborted

Expand to view the summary

Build stats

Start Time: 2023-12-18T12:48:47.560+0000
Duration: 5 min 39 sec

Steps errors

Expand to view the steps failures

`Load a resource file from a library`

Took 0 min 0 sec . View more details here
Description: approval-list/elastic/beats.yml

`Error signal`

Took 0 min 0 sec . View more details here
Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/zipperle return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/zipperle : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/zipperle : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/orgs/members#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

pierrehilbert · 2023-12-18T17:00:33Z

@zipperle did you sign our CLA?

pierrehilbert · 2024-01-02T13:24:08Z

Setting back to draft in the meantime.

zipperle · 2024-01-08T14:29:05Z

@pierrehilbert yes I have signed the CLA

elasticmachine · 2024-01-08T14:34:33Z

❕ Build Aborted

Expand to view the summary

Build stats

Start Time: 2024-01-08T14:29:38.161+0000
Duration: 5 min 49 sec

Steps errors

Expand to view the steps failures

`Load a resource file from a library`

Took 0 min 0 sec . View more details here
Description: approval-list/elastic/beats.yml

`Error signal`

Took 0 min 0 sec . View more details here
Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/zipperle return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/zipperle : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/zipperle : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/orgs/members#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

pierrehilbert · 2024-01-18T17:17:01Z

/test

elasticmachine · 2024-01-18T19:29:52Z

💚 Build Succeeded

Expand to view the summary

Build stats

Duration: 132 min 24 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

fearful-symmetry

Seems reasonable. @ycombinator has a little more experience with the fingerprint processor, maybe he'll notice something I don't.

ycombinator · 2024-02-01T23:30:10Z

libbeat/processors/fingerprint/fingerprint_test.go

+	assert.NoError(t, err)
+	p, err := New(testConfig)
+	assert.NoError(t, err)
+	assert.Equal(t, `fingerprint={"Method":"md5","Encoding":"hex","Fields":["field1"],"TargetField":"fingerprint","IgnoreMissing":false}`, fmt.Sprint(p))


Suggest using require.* instead of assert.*.

ycombinator

Changes LGTM. Thank you for fixing!

Just made a minor suggestion about the test assertions, that's all.

elasticmachine · 2024-02-02T11:26:59Z

💚 Build Succeeded

Expand to view the summary

Build stats

Duration: 132 min 58 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

mergify · 2024-02-05T14:26:51Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @zipperle? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

pierrehilbert · 2024-02-05T15:46:15Z

Thx @zipperle we are now all good to be merged!
Your change will be in our next minor version release.

Fix Stringer implementation of fingerprint processor

e8d0bbb

zipperle requested a review from a team as a code owner August 30, 2023 20:25

zipperle requested review from fearful-symmetry and leehinman August 30, 2023 20:25

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 30, 2023

mergify bot assigned zipperle Aug 30, 2023

pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Aug 31, 2023

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 31, 2023

zipperle closed this Nov 5, 2023

zipperle force-pushed the main branch from 5a3c0fb to 024a9ce Compare November 5, 2023 09:48

Merge remote-tracking branch 'upstream/main'

c4135a4

zipperle reopened this Nov 5, 2023

Fix the linter issues

5c6fb05

Merge branch 'main' into main

89d482e

zipperle and others added 3 commits November 13, 2023 22:43

Merge branch 'main' into main

1ec3c5f

Merge branch 'main' into main

a79a0f1

Merge branch 'main' into main

3c7e466

Merge branch 'main' into main

8526257

pierrehilbert marked this pull request as draft January 2, 2024 13:24

zipperle marked this pull request as ready for review January 8, 2024 14:29

Merge branch 'main' into main

cab9f38

fearful-symmetry approved these changes Feb 1, 2024

View reviewed changes

ycombinator reviewed Feb 1, 2024

View reviewed changes

Tests: use require instead of assert.

b39c30c

ycombinator approved these changes Feb 2, 2024

View reviewed changes

pierrehilbert merged commit 12b73b7 into elastic:main Feb 5, 2024
86 checks passed

Fix Stringer implementation of fingerprint processor #36468

Fix Stringer implementation of fingerprint processor #36468

Conversation

zipperle commented Aug 30, 2023

Proposed commit message

Checklist

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

mergify bot commented Aug 30, 2023

elasticmachine commented Aug 30, 2023 • edited by jenkins-beats-ci bot Loading

❕ Build Aborted

Build stats

Steps errors

Load a resource file from a library

Error signal

🤖 GitHub comments

mergify bot commented Sep 7, 2023

cmacknz commented Sep 8, 2023

mergify bot commented Sep 22, 2023

mergify bot commented Oct 2, 2023

cmacknz commented Oct 16, 2023

pierrehilbert commented Oct 25, 2023

mergify bot commented Nov 5, 2023

zipperle commented Nov 5, 2023

pierrehilbert commented Nov 8, 2023

elasticmachine commented Nov 16, 2023

❕ Build Aborted

Build stats

Steps errors

Load a resource file from a library

Error signal

🤖 GitHub comments

elasticmachine commented Dec 18, 2023

❕ Build Aborted

Build stats

Steps errors

Load a resource file from a library

Error signal

🤖 GitHub comments

pierrehilbert commented Dec 18, 2023

pierrehilbert commented Jan 2, 2024

zipperle commented Jan 8, 2024

elasticmachine commented Jan 8, 2024

❕ Build Aborted

Build stats

Steps errors

Load a resource file from a library

Error signal

🤖 GitHub comments

pierrehilbert commented Jan 18, 2024

elasticmachine commented Jan 18, 2024

💚 Build Succeeded

Build stats

❕ Flaky test report

🤖 GitHub comments

fearful-symmetry left a comment

Choose a reason for hiding this comment

ycombinator Feb 1, 2024

Choose a reason for hiding this comment

ycombinator left a comment

Choose a reason for hiding this comment

elasticmachine commented Feb 2, 2024

💚 Build Succeeded

Build stats

❕ Flaky test report

🤖 GitHub comments

mergify bot commented Feb 5, 2024

pierrehilbert commented Feb 5, 2024

elasticmachine commented Aug 30, 2023 •

edited by jenkins-beats-ci bot

Loading

`Load a resource file from a library`

`Error signal`

`Load a resource file from a library`

`Error signal`

`Load a resource file from a library`

`Error signal`

`Load a resource file from a library`

`Error signal`