packetbeat/beater: deduplicate interface configs #36576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
Packetbeat
Team:Security-External Integrations
8.11-candidate
backport-v8.10.0
botelastic
bot
added
needs_team
efd6
force-pushed
the
36574-packetbeat_deduplicated_interfaces
branch
from
bb29d4d to
e4b74fa
Compare
3 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
efd6
force-pushed
the
36574-packetbeat_deduplicated_interfaces
branch
from
e4b74fa to
9efeb94
Compare
When a config is provided by fleet, it will contain multiple definitions of the same interface, and in future we may allow individual datastreams to specify their own interface, so allow multiple distinct interfaces, but ensure that no interfaces have the same configuration by removing duplicates.
efd6
force-pushed
the
36574-packetbeat_deduplicated_interfaces
branch
from
9efeb94 to
61902ae
Compare
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
mergify bot
pushed a commit
that referenced
this pull request
Sep 21, 2023
When a config is provided by fleet, it will contain multiple definitions of the same interface, and in future we may allow individual datastreams to specify their own interface, so allow multiple distinct interfaces, but ensure that no interfaces have the same configuration by removing duplicates. (cherry picked from commit edc9851)
efd6
added a commit
that referenced
this pull request
Sep 21, 2023
When a config is provided by fleet, it will contain multiple definitions of the same interface, and in future we may allow individual datastreams to specify their own interface, so allow multiple distinct interfaces, but ensure that no interfaces have the same configuration by removing duplicates. (cherry picked from commit edc9851) Co-authored-by: Dan Kortschak <[email protected]>
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
When a config is provided by fleet, it will contain multiple definitions of the same interface, and in future we may allow individual datastreams to specify their own interface, so allow multiple distinct interfaces, but ensure that no interfaces have the same configuration by removing duplicates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
When a config is provided by fleet, it will contain multiple definitions
of the same interface, and in future we may allow individual datastreams
to specify their own interface, so allow multiple distinct interfaces,
but ensure that no interfaces have the same configuration by removing
duplicates.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs