Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make file system metadata values strings #36697

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Conversation

rdner
Copy link
Member

@rdner rdner commented Sep 28, 2023

To better align with ECS and better store the values in Elasticsearch.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

See steps in #36065

Related issues

To better align with ECS and better store the values in Elasticsearch.
@rdner rdner added enhancement Filebeat Filebeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Sep 28, 2023
@rdner rdner self-assigned this Sep 28, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 28, 2023
@bhapas
Copy link
Contributor

bhapas commented Sep 28, 2023

Possible to backport this to 8.10 ?

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 28, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-28T08:52:45.079+0000

  • Duration: 71 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 28350
Skipped 2013
Total 30363

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@rdner
Copy link
Member Author

rdner commented Sep 28, 2023

@jlind23 it's technically a breaking change, do you think we can backport it to 8.10 anyway? It would fix some things for integration developers.

@jlind23
Copy link
Collaborator

jlind23 commented Sep 28, 2023

@rdner No we shouldn't backport any breaking change in a patch release. 8.11 is lined up to be out soon so better stick with 8.11. Moreover if it's a breaking change, we need to have a proper entry in the release note for this.

@rdner rdner marked this pull request as ready for review September 28, 2023 08:55
@rdner rdner requested a review from a team as a code owner September 28, 2023 08:55
@rdner rdner requested a review from faec September 28, 2023 08:55
@rdner rdner added the backport-skip Skip notification from the automated backport with mergify label Sep 28, 2023
@elastic elastic deleted a comment from mergify bot Sep 28, 2023
@rdner rdner enabled auto-merge (squash) September 28, 2023 08:57
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rdner rdner merged commit 8dcf23c into elastic:main Sep 28, 2023
@rdner rdner deleted the file-metadata-types branch September 28, 2023 18:41
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
To better align with ECS and better store the values in Elasticsearch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.11-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat] filestream input : Change file system information fields to string
5 participants