Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/internal/httplog: fix incorrect append source #36956

Merged
merged 1 commit into from
Oct 25, 2023
Merged

x-pack/filebeat/input/internal/httplog: fix incorrect append source #36956

merged 1 commit into from
Oct 25, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Oct 25, 2023

Proposed commit message

See title.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 self-assigned this Oct 25, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 25, 2023
@efd6 efd6 force-pushed the httptracemisappend branch from 3478f61 to 10afcba Compare October 25, 2023 00:57
@efd6 efd6 marked this pull request as ready for review October 25, 2023 00:57
@efd6 efd6 requested a review from a team as a code owner October 25, 2023 00:57
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 mentioned this pull request Oct 25, 2023
Merged
6 tasks
@efd6
Copy link
Contributor Author

efd6 commented Oct 25, 2023

/package

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 25, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-25T08:30:08.780+0000

  • Duration: 107 min 34 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

bhapas
bhapas approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6
Copy link
Contributor Author

efd6 commented Oct 25, 2023

/test

@efd6 efd6 enabled auto-merge (squash) October 25, 2023 08:30
@efd6 efd6 merged commit bbf0111 into elastic:main Oct 25, 2023
mergify bot pushed a commit that referenced this pull request Oct 25, 2023
@efd6 @mergify
x-pack/filebeat/input/internal/httplog: fix incorrect append source (#…
a8c6bc3 
…36956)

(cherry picked from commit bbf0111)
@mergify mergify bot mentioned this pull request Oct 25, 2023
Merged
efd6 added a commit that referenced this pull request Oct 25, 2023
@mergify @efd6
[8.11](backport #36956) x-pack/filebeat/input/internal/httplog: fix i…
fd0446f 
…ncorrect append source (#36959)

* x-pack/filebeat/input/internal/httplog: fix incorrect append source (#36956)

(cherry picked from commit bbf0111)

* remove irrelevant changelog lines

---------

Co-authored-by: Dan Kortschak <[email protected]>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@efd6 @Scholar-Li
x-pack/filebeat/input/internal/httplog: fix incorrect append source (e…
b908b84 
…lastic#36956)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhapas bhapas bhapas approved these changes

Assignees

@efd6 efd6

Labels
8.12-candidate backport-v8.11.0 Automated backport with mergify bug Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @bhapas