Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Beats] Adding support for elastic-agent-autodiscovery v0.6.13 Introduce log message for not supported annotations #38213
[Beats] Adding support for elastic-agent-autodiscovery v0.6.13 Introduce log message for not supported annotations #38213
Changes from 19 commits
6dba856
39b32e9
8c08dff
51728af
4009d15
6985610
e023e50
4661676
3e1e1fb
edb7c3a
3542df5
7d2c429
0e00df6
382ef5f
24b07fb
9a5ad55
bce8fc7
9decff6
e161254
0a40b85
2e6ad5f
142f1ac
dbd20e5
2d19a40
1c10c37
55451c6
e159e75
097b7ea
08f3c60
bf441cf
92c266b
05d71ef
95f30aa
ea50b00
f3b6f21
58da62a
e3ca45d
6e282d0
e0c255d
8ae7814
58f476f
63131b2
14815b2
7954069
7bfd450
7b5a9bb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't know we call
GenerateHints
here. Looking on this use case, wondering if it wouldn't be a better option to introduce additionally smth likeGenerateHintsWithValidation
instead - maybe we should consider it in future for cases when signature is changedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here
GenerateHints
will actually return all hints as incorrect but we just ignore them. I think we should make it more clear. Maybe add a bool (validate
), which is then checked in GenerateHintsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: elastic/elastic-agent-autodiscover#89
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be
host
orhosts
? https://www.elastic.co/guide/en/beats/metricbeat/current/configuration-autodiscover-hints.html#_co_elastic_metricshostsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch @tetianakravchenko . In beats it is "hosts"
Although in elastic-agent should be host
(https://github.com/elastic/elastic-agent/blob/main/internal/pkg/composable/providers/kubernetes/hints.go#L49)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated in 55451c6 and also added some test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was done in order to remove:
Consider pre-allocating
events(prealloc)
lint error