-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clean_inactive for Filestream input #38632
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
a2fbcb8
to
75f4d84
Compare
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the linter issue needs to be fixed.
4ea05a5
to
2f7d96a
Compare
This pull request is now in conflicts. Could you fix it? 🙏
|
6c8e815
to
b37756d
Compare
filebeat/docs/fields.asciidoc
Outdated
@@ -111136,6 +111136,13 @@ type: keyword | |||
|
|||
-- | |||
|
|||
*`o365.audit.Activity`*:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated to the PR, but when I run mage check
it got generated.
/test |
9c594c4
to
866f57a
Compare
The `clean_inactive` parameter was being parsed with the wrong key. It is parsed/used by an anonymous struct on `input-logfile/manager.go`, there it was parsed and used as `CleanTimeout` (`clean_timeout`). This `CleanTimeout` setting has got exactly the same effect as the `clean_inactive` described in our documentation. This commit fixes this bug by renaming `clean_timeout` to `clean_inactive` so the configuration value can have effect.
- Rename `CleanTimeout` to `CleanInactive` - Remove commented out code
866f57a
to
cba57bb
Compare
Thank you all. |
Proposed commit message
The
clean_inactive
parameter was being parsed with the wrong key. Itis parsed/used by an anonymous struct on
input-logfile/manager.go
,there it was parsed and used as
CleanTimeout
(clean_timeout
). ThisCleanTimeout
setting has got exactly the same effect as theclean_inactive
described in our documentation.This commit fixes this bug by renaming
clean_timeout
toclean_inactive
so the configuration value can have effect.Checklist
[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
main
How to test this PR locally
All files are at the end of this section.
filebeat.yml
data/registry/filebeat/log.json
) contains an remove operation like this:filebeat.yml
Related issues
clean_inactive
#36629## Use cases## Screenshots## Logs