Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs][Elasticsearch] Specify metricsets list behaviour with xpack mode enabled #39612

Merged
merged 1 commit into from
May 22, 2024

Conversation

tonyghiani
Copy link
Contributor

Based on an offline conversation, when the xpack.enabled: true for the elasticsearch module, the documentation didn't clearly state the expected metricset list when the metricsets property is still set to some entries.

This update should clarify what happens when both xpack.enabled: true and metricsets are configured.

@tonyghiani tonyghiani added the Team:Monitoring Stack Monitoring team label May 17, 2024
@tonyghiani tonyghiani requested a review from a team as a code owner May 17, 2024 10:09
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 17, 2024
Copy link
Contributor

mergify bot commented May 17, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @tonyghiani? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this!

@tonyghiani tonyghiani merged commit 96f4afc into main May 22, 2024
19 of 20 checks passed
@tonyghiani tonyghiani deleted the update-elasticsearch-module-docs branch May 22, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Monitoring Stack Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants