Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update x-pack/metricbeat & x-pack/filebeat pipellines to match Jenkins on 7.17 #39744

Merged
merged 18 commits into from
Jul 1, 2024
Merged

Update x-pack/metricbeat & x-pack/filebeat pipellines to match Jenkins on 7.17 #39744

merged 18 commits into from
Jul 1, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented May 27, 2024 •
edited
Loading

Proposed commit message

  • Updated x-pack/metricbeat pipeline to match Jenkins steps and common styling
  • Updated cloud env setup script (enabled TF setup retries as originally was on Jenkins)
  • Optimized cloud test steps (more details - https://github.com/elastic/ingest-dev/issues/3399) for x-pack/metricbeat && x-pack/filebeat
  • Enabled AWS tests for x-pack/metricbeat
  • Removed docker-compose from deploy/docker folder, since no localstack tests exist on 7.17
  • Skipped AWS tests for x-pack/filebeat due to https://github.com/elastic/ingest-dev/issues/3467

Metricbeat Go Integration test failure is not related with changes in current PR and will be fixed with #39908.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • .buildkite/x-pack/pipeline.xpack.filebeat.yml
  • .buildkite/x-pack/pipeline.xpack.metricbeat.yml
  • .buildkite/scripts/initCloudEnv.sh

Related issues

Logs

BK builds: https://buildkite.com/elastic/beats-xpack-metricbeat/builds?branch=oakrizan%3Axpack-metricbeat-postmigration-fixes-7-17

@oakrizan oakrizan added :Windows ci macOS Enable builds in the CI for darwin testing arm Enable builds in the CI for ARM testing 7.12 candidate Team:Ingest-EngProd labels May 27, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 27, 2024
@oakrizan oakrizan added aws Enable builds in the CI for aws cloud testing and removed 7.12 candidate labels May 27, 2024
@oakrizan
Copy link
Contributor Author

/test

@oakrizan oakrizan force-pushed the xpack-metricbeat-postmigration-fixes-7-17 branch 9 times, most recently from 28353fc to c7055ba Compare May 28, 2024 15:07
@oakrizan oakrizan force-pushed the xpack-metricbeat-postmigration-fixes-7-17 branch 8 times, most recently from 43c07fe to 292d296 Compare June 4, 2024 11:54
@oakrizan oakrizan force-pushed the xpack-metricbeat-postmigration-fixes-7-17 branch 3 times, most recently from ffa3199 to ab48bc9 Compare June 14, 2024 21:18
@oakrizan oakrizan force-pushed the xpack-metricbeat-postmigration-fixes-7-17 branch from ab48bc9 to a5b8b72 Compare June 14, 2024 21:18
@oakrizan oakrizan force-pushed the xpack-metricbeat-postmigration-fixes-7-17 branch from 8eb83cb to 79e947a Compare June 14, 2024 21:56
@oakrizan oakrizan requested review from dliappis and alexsapran June 15, 2024 08:23
@oakrizan oakrizan marked this pull request as ready for review June 15, 2024 08:26
@oakrizan oakrizan requested a review from a team as a code owner June 15, 2024 08:26
@oakrizan oakrizan enabled auto-merge (squash) June 17, 2024 09:44
@oakrizan oakrizan changed the title Update x-pack/metricbeat pipelline to match Jenkins on 7.17 Update x-pack/metricbeat & x-pack/filebeat pipellines to match Jenkins on 7.17 Jun 20, 2024
@oakrizan oakrizan requested a review from pazone June 20, 2024 08:00
@Micheal-Madhan Micheal-Madhan mentioned this pull request Jun 20, 2024
Closed
@oakrizan
Copy link
Contributor Author

oakrizan commented Jul 1, 2024

PTAL @dliappis @pazone

dliappis
dliappis approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; left a minor question that doesn't need another review cycle

.buildkite/x-pack/pipeline.xpack.metricbeat.yml
# docker-compose problem debugging
which docker-compose
docker-compose --version
pwd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this debugging section still needed?

@oakrizan oakrizan merged commit e5bb449 into elastic:7.17 Jul 1, 2024
152 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@alexsapran alexsapran Awaiting requested review from alexsapran

@pazone pazone Awaiting requested review from pazone

Assignees

@oakrizan oakrizan

Labels
arm Enable builds in the CI for ARM testing aws Enable builds in the CI for aws cloud testing ci macOS Enable builds in the CI for darwin testing Team:Ingest-EngProd :Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oakrizan @dliappis @pazone