beats: import time/tzdata explicitly in main #40420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
In order to handle timezones we import Go's own timezone database. This import is done indirectly by libbeat/common/cfgtype. We trust that this package will end up being required by the dependency chain of every beats main binary. To ensure that the binaries continue to handle timezones correctly and to avoid any unexpected issues, let's import time/tzdata explicitly in the main packages. See elastic#40326.
mauri870
force-pushed
the
feature/tzdata-main
branch
from
68e92c1 to
5459933
Compare
pierrehilbert
added
Team:obs-ds-hosted-services
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
botelastic
bot
removed
the
needs_team
|
/test |
rdner
approved these changes
Aug 2, 2024
taylor-swanson
approved these changes
Aug 2, 2024
|
/test |
|
run docs-build |
nfritts
approved these changes
Aug 7, 2024
belimawr
approved these changes
Aug 7, 2024
|
/test |
|
run docs-build |
|
@graphaelli could you please find someone to review here as @bturquet is currently out? |
axw
approved these changes
Aug 12, 2024
vinit-chauhan
pushed a commit
to vinit-chauhan/beats
that referenced
this pull request
Aug 13, 2024
In order to handle timezones we import Go's own timezone database. This import is done indirectly by libbeat/common/cfgtype. We trust that this package will end up being required by the dependency chain of every beats main binary. To ensure that the binaries continue to handle timezones correctly and to avoid any unexpected issues, let's import time/tzdata explicitly in the main packages. See elastic#40326. Co-authored-by: Pierre HILBERT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
In order to handle timezones we import Go's own timezone database. This
import is done indirectly by libbeat/common/cfgtype. We trust that this
package will end up being required by the dependency chain of every beats
main binary.
To ensure that the binaries continue to handle timezones correctly even if the
indirect import is removed let's import time/tzdata explicitly in the main packages.
See discussion at #40326.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs