Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #41970) [filebeat][gcs] - Removed bucket_timeout config option and replaced bucket context with parent program context #41987

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 11, 2024

Type of change

  • Deprecation
  • Docs

Proposed commit message

  • WHAT: Removed bucket_timeout config option and replaced bucket context with parent program context
  • WHY: The bucket_timeout option was used to specify the timeout for the individual bucket operations. This option was
    difficult to understand in its effects resulting in malconfiguration leading to processing timeouts and context cancellation, ultimately causing gaps in the ingested data. To avoid this, the bucket_timeout option has been removed. The input now uses the parent program context to handle the contexts for bucket operations.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Since it is a config option that has not impact on ingested data, this removal should not have any user impact.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #41970 done by [Mergify](https://mergify.com).

…ucket context with parent program context (#41970)

(cherry picked from commit 002a220)
@mergify mergify bot requested a review from a team as a code owner December 11, 2024 06:34
@mergify mergify bot added the backport label Dec 11, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 11, 2024
@botelastic
Copy link

botelastic bot commented Dec 11, 2024

This pull request doesn't have a Team:<team> label.

@ShourieG
Copy link
Contributor

/test

@ShourieG ShourieG merged commit f468019 into 8.x Dec 11, 2024
20 of 22 checks passed
@ShourieG ShourieG deleted the mergify/bp/8.x/pr-41970 branch December 11, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant