Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/awss3: fix document ID construction when using csv decoder #42019

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

x-pack/filebeat/input/awss3: fix document ID construction when using csv decoder #42019

wants to merge 2 commits into from
+23 −10

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Dec 12, 2024 •
edited
Loading

Proposed commit message

See title.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added Filebeat Filebeat bugfix Team:Security-Service Integrations Security Service Integrations Team backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify labels Dec 12, 2024
@efd6 efd6 self-assigned this Dec 12, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 12, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 12, 2024
@efd6 efd6 force-pushed the s3_valueDecoder_offset branch from f456d3c to 849ff10 Compare December 12, 2024 19:52
@efd6 efd6 changed the title x-pack/filebeat/input/awss3: fix document ID construction when using … x-pack/filebeat/input/awss3: fix document ID construction when using https://github.com/elastic/beats/pull/42019 Dec 12, 2024
@efd6 efd6 changed the title x-pack/filebeat/input/awss3: fix document ID construction when using https://github.com/elastic/beats/pull/42019 x-pack/filebeat/input/awss3: fix document ID construction when using csv decoder Dec 12, 2024
@efd6 efd6 marked this pull request as ready for review December 13, 2024 05:28
@efd6 efd6 requested a review from a team as a code owner December 13, 2024 05:28
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@efd6 efd6

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify bugfix Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @andrewkroh