Fix flaky logstash output test #43402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faec
added
flaky-test
botelastic
bot
added
needs_team
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
belimawr
approved these changes
Mar 20, 2025
AndersonQ
approved these changes
Mar 24, 2025
|
/test |
mergify bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
Fix a flaky logstash output test for the `deadlockListener`. The old test used live time tickers and occasionally failed because timing on CI machines is highly variable. This PR refactors `deadlockListener` to allow tests to override the current time and the ticker channel, so the test can run deterministically in a single goroutine with no calls to `time.Sleep`. (cherry picked from commit 6d92a40)
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
Fix a flaky logstash output test for the `deadlockListener`. The old test used live time tickers and occasionally failed because timing on CI machines is highly variable. This PR refactors `deadlockListener` to allow tests to override the current time and the ticker channel, so the test can run deterministically in a single goroutine with no calls to `time.Sleep`. (cherry picked from commit 6d92a40)
mergify bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
Fix a flaky logstash output test for the `deadlockListener`. The old test used live time tickers and occasionally failed because timing on CI machines is highly variable. This PR refactors `deadlockListener` to allow tests to override the current time and the ticker channel, so the test can run deterministically in a single goroutine with no calls to `time.Sleep`. (cherry picked from commit 6d92a40) # Conflicts: # libbeat/outputs/logstash/deadlock.go # libbeat/outputs/logstash/deadlock_test.go
This was referenced Mar 24, 2025
mergify bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
Fix a flaky logstash output test for the `deadlockListener`. The old test used live time tickers and occasionally failed because timing on CI machines is highly variable. This PR refactors `deadlockListener` to allow tests to override the current time and the ticker channel, so the test can run deterministically in a single goroutine with no calls to `time.Sleep`. (cherry picked from commit 6d92a40) # Conflicts: # libbeat/outputs/logstash/deadlock.go # libbeat/outputs/logstash/deadlock_test.go
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
Fix a flaky logstash output test for the `deadlockListener`. The old test used live time tickers and occasionally failed because timing on CI machines is highly variable. This PR refactors `deadlockListener` to allow tests to override the current time and the ticker channel, so the test can run deterministically in a single goroutine with no calls to `time.Sleep`. (cherry picked from commit 6d92a40)
mergify bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
Fix a flaky logstash output test for the `deadlockListener`. The old test used live time tickers and occasionally failed because timing on CI machines is highly variable. This PR refactors `deadlockListener` to allow tests to override the current time and the ticker channel, so the test can run deterministically in a single goroutine with no calls to `time.Sleep`. (cherry picked from commit 6d92a40) # Conflicts: # libbeat/outputs/logstash/deadlock.go # metricbeat/module/beat/beat_external_test.go
This was referenced Mar 24, 2025
faec
added a commit
that referenced
this pull request
Mar 24, 2025
Fix a flaky logstash output test for the `deadlockListener`. The old test used live time tickers and occasionally failed because timing on CI machines is highly variable. This PR refactors `deadlockListener` to allow tests to override the current time and the ticker channel, so the test can run deterministically in a single goroutine with no calls to `time.Sleep`. (cherry picked from commit 6d92a40) Co-authored-by: Fae Charlton <[email protected]>
pierrehilbert
pushed a commit
that referenced
this pull request
Mar 25, 2025
Fix a flaky logstash output test for the `deadlockListener`. The old test used live time tickers and occasionally failed because timing on CI machines is highly variable. This PR refactors `deadlockListener` to allow tests to override the current time and the ticker channel, so the test can run deterministically in a single goroutine with no calls to `time.Sleep`. (cherry picked from commit 6d92a40) Co-authored-by: Fae Charlton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a flaky logstash output test for the
deadlockListener. The old test used live time tickers and occasionally failed because timing on CI machines is highly variable. This PR refactorsdeadlockListenerto allow tests to override the current time and the ticker channel, so the test can run deterministically in a single goroutine with no calls totime.Sleep.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.