-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "bk(dra): split arm64 for linux and darwin from amd64" #43404
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 3823c01.
This pull request doesn't have a |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Wait, we are merging things, so there might be instability, but this should not be done now |
We have probably forgot to say that we are working on it: Status for Beats:
In your case the failure is about a PR in one of those branches. Sorry for the noise, but we are actually working as we speak |
That's in main, interestingly it has not been found in those PRs:
So we need some help so we can keep using the approach we have done so far:
|
The crosscompile failures were in the main branch (on #43394), but I will rerun the tests there to see if they're working again now |
If it works in main:
Maybe it's something with your PR or maybe it's not up-to-date? |
@v1v The split PR looks like it didn't actually run those tests before merge, which I think was an error in the CI itself? But it does seem to have passed on its post-merge run in main. If it doesn't happen anymore then the rollback is unnecessary :-) |
Thanks @faec for double-checking and so sorry for missing the way to communicate this!! 🥺 |
There are two PRs:
In both cases, we changed in the golang-crossbuild the support for That change forced us to use #43387 didn't test anything because for some reason the CI has not been configured to test changes in that pipeline, as far as I understood (why? no clue, that's something I have not been involved). However, I hope I clarified a bit the context, but If I missed something please let me know, just in case something else is not right! Thanks again @faec |
Reverts #43387
This PR is breaking the metricbeat packaging (https://buildkite.com/elastic/beats-xpack-metricbeat/builds/13512#0195b4ca-f2d5-44f7-8e12-486a28814556) and crosscompile (https://buildkite.com/elastic/beats-metricbeat/builds/15782#0195b4ea-77a7-482c-be10-f27ea95bd74f) tests. A dependency check bug seems to have skipped those tests (and most others) on the PR's CI, which made it appear green before merge.