[FR] Add white space checking for KQL parse #3789
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#2700
Summary
This addresses an issue where lark parses KQL queries without whitespace around certain tokens, where KQL does not.
E.g.
"Get-NetComputerSiteName" or "Get-NetLocalGroup"
vs"Get-NetComputerSiteName" or"Get-NetLocalGroup"
. Both of which parse via lark/ANTLR, but the second fails in Kibana.Some notes about alternative implementations:
This approach adds a post-processing step to the lark parsing to tell us where the and and or tokens are in the original string, then compare to see if those tokens locations have the appropriate spacing.
Note since this PR updates the KQL lib please make sure to update the KQL lib version appropriately.
Contributor checklist