Skip to content

Remove ess apply labels from LDAP, PKI, and AD authentication pages #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Apr 25, 2025

This fixes the applies_to tagging for LDAP user authentication and Active Directory user authentication to apply to ECE only (rather than ECE, hosted, self, and K8s) no longer apply to ECH (according to Shaina's comment below these still apply to self-hosted and K8s).

Added the PKI page too.

@kilfoyle kilfoyle requested a review from georgewallace April 25, 2025 18:46
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tutorials are shared, so they still apply to self-hosted and eck.

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Apr 25, 2025

Okay. I've removed only the ess labels from those three pages.

@kilfoyle kilfoyle changed the title Fix tagging for LDAP and AD to be ECE-only Remove ess apply labels from LDAP, PKI, and AD authentication pages Apr 25, 2025
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you and sorry! 🙏

shainaraskas

This comment was marked as duplicate.

@kilfoyle kilfoyle merged commit 557918f into elastic:main Apr 25, 2025
4 checks passed
@kilfoyle
Copy link
Contributor Author

No worries @shainaraskas. :-) Nice to have this fixed up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants