Skip to content

Update Codeowners file #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Codeowners file #609

wants to merge 1 commit into from

Conversation

bmorelli25
Copy link
Member

Summary

This PR updates codeowners in this repository. I am looking for feedback. This is just a draft and I'm certain I got some things wrong. Thank you!

/explore-analyze/ @elastic/platform-docs
/extend/ @elastic/platform-docs
/get-started/ @elastic/platform-docs
/manage-data/ @elastic/platform-docs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one needs some nuance - /manage-data/ingestion/ needs to go to obs

/solutions/ @elastic/obs-docs @elastic/search-docs @elastic/security-docs
/solutions/observability/ @elastic/obs-docs
/solutions/search/ @elastic/search-docs
/solutions/security @elastic/security-docs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what the rules are but this one breaks the pattern

Suggested change
/solutions/security @elastic/security-docs
/solutions/security/ @elastic/security-docs

/extend/ @elastic/platform-docs
/get-started/ @elastic/platform-docs
/manage-data/ @elastic/platform-docs
/reference/ @elastic/platform-docs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have some shared ownership down below here. there's obs, sec, ingest sections. don't know how picky we want to be about splitting up the folder, but platform shouldn't be the only owner

https://github.com/elastic/docs-content/tree/main/reference

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I think at least the following makes sense. For data-analysis and ingestion-tools they are split across the teams. data-analysis we could subfolder. Ingestion-tools I think maybe should be all obs-docs by the looks of it.

folder team
reference/data-analysis ?
reference/elasticsearch/clients platform-docs
reference/glossary docs
reference/ingestion-tools ?
reference/observability obs-docs
reference/search platform-docs
reference/security security-docs

/manage-data/ @elastic/platform-docs
/reference/ @elastic/platform-docs
/release-notes/ @elastic/docs
/solutions/ @elastic/obs-docs @elastic/search-docs @elastic/security-docs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd skip using search docs (@georgewallace to confirm)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Shaina, for now can just do platform-docs

/release-notes/ @elastic/docs
/solutions/ @elastic/obs-docs @elastic/search-docs @elastic/security-docs
/solutions/observability/ @elastic/obs-docs
/solutions/search/ @elastic/search-docs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

/solutions/observability/ @elastic/obs-docs
/solutions/search/ @elastic/search-docs
/solutions/security @elastic/security-docs
/troubleshoot/ @elastic/docs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could be more targeted about the child items here. suggest we apply the same strategy to this section as we do to reference

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree., the sub folders make quite a bit of sense to me.

Copy link
Contributor

@georgewallace georgewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my comments

/extend/ @elastic/platform-docs
/get-started/ @elastic/platform-docs
/manage-data/ @elastic/platform-docs
/reference/ @elastic/platform-docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I think at least the following makes sense. For data-analysis and ingestion-tools they are split across the teams. data-analysis we could subfolder. Ingestion-tools I think maybe should be all obs-docs by the looks of it.

folder team
reference/data-analysis ?
reference/elasticsearch/clients platform-docs
reference/glossary docs
reference/ingestion-tools ?
reference/observability obs-docs
reference/search platform-docs
reference/security security-docs

/manage-data/ @elastic/platform-docs
/reference/ @elastic/platform-docs
/release-notes/ @elastic/docs
/solutions/ @elastic/obs-docs @elastic/search-docs @elastic/security-docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Shaina, for now can just do platform-docs

/solutions/observability/ @elastic/obs-docs
/solutions/search/ @elastic/search-docs
/solutions/security @elastic/security-docs
/troubleshoot/ @elastic/docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree., the sub folders make quite a bit of sense to me.

/explore-analyze/ @elastic/platform-docs
/extend/ @elastic/platform-docs
/get-started/ @elastic/platform-docs
/manage-data/ @elastic/platform-docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/manage-data/ @elastic/platform-docs
/manage-data/ @elastic/platform-docs
/manage-data/ingestion/ @elastic/obs-docs

/extend/ @elastic/platform-docs
/get-started/ @elastic/platform-docs
/manage-data/ @elastic/platform-docs
/reference/ @elastic/platform-docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/reference/ @elastic/platform-docs
/reference/ @elastic/docs
/reference/data-analysis/ @elastic/docs
/reference/data-analysis/kibana/ @elastic/platform-docs
/reference/data-analysis/machine-learning/ @elastic/platform-docs
/reference/data-analysis/observability/ @elastic/obs-docs
/reference/elasticsearch/clients/ @elastic/platform-docs
/reference/glossary @elastic/docs
/reference/ingestion-tools/ @elastic/obs-docs
/reference/observability @elastic/obs-docs
/reference/search @elastic/platform-docs
/reference/security @elastic/security-docs

/manage-data/ @elastic/platform-docs
/reference/ @elastic/platform-docs
/release-notes/ @elastic/docs
/solutions/ @elastic/obs-docs @elastic/search-docs @elastic/security-docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/solutions/ @elastic/obs-docs @elastic/search-docs @elastic/security-docs
/solutions/ @elastic/obs-docs @elastic/platform-docs @elastic/security-docs

/release-notes/ @elastic/docs
/solutions/ @elastic/obs-docs @elastic/search-docs @elastic/security-docs
/solutions/observability/ @elastic/obs-docs
/solutions/search/ @elastic/search-docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/solutions/search/ @elastic/search-docs
/solutions/search/ @elastic/platform-docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants