Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECK 2.16 #3138

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Add ECK 2.16 #3138

merged 2 commits into from
Dec 18, 2024

Conversation

naemono
Copy link
Contributor

@naemono naemono commented Dec 6, 2024

This adds the ECK 2.16 branch to the build list. ECK 2.16.0 is planned for release on December 12th.

This has been delayed to Dec 19th.

Signed-off-by: Michael Montgomery <[email protected]>
@naemono naemono requested a review from a team as a code owner December 6, 2024 16:06
Copy link

github-actions bot commented Dec 6, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@naemono naemono enabled auto-merge (squash) December 18, 2024 16:41
@naemono
Copy link
Contributor Author

naemono commented Dec 18, 2024

@elastic/docs-repo-owners Could anyone give this a review please? The linked buildkite build did pass after a retry.

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@naemono
Copy link
Contributor Author

naemono commented Dec 18, 2024

LGTM! 🚀

thank you for the review, but how do I get this merged since the docs build shows failed but actually succeeded?

@kilfoyle
Copy link
Contributor

kilfoyle commented Dec 18, 2024

@naemono The docs-build-pr CI check log shows this error:

WARNING: invalid reference: release-notes-2.16.0

I'm confused as to why this fails though, because I do see that release-notes-2.16.0 file here in the cloud-on-k8s repo's 2.16 branch.

@naemono
Copy link
Contributor Author

naemono commented Dec 18, 2024

@naemono The docs-build-pr CI check log shows this error:

WARNING: invalid reference: release-notes-2.16.0

I'm confused as to why this fails though, because I do see that release-notes-2.16.0 file here in the cloud-on-k8s repo's 2.16 branch.

it wasn't originally in that Branch, and that was fixed yesterday so I think the logs you're looking at may be outdated

@kilfoyle
Copy link
Contributor

@naemono Sorry, I missed that the docs build passed on the second run. I've just pushed an empty commit to this PR to relaunch everything, and hopefully that will be the magic we need. :-)

@naemono naemono merged commit b4e8323 into elastic:master Dec 18, 2024
3 checks passed
@naemono naemono deleted the eck-2.16.0 branch December 18, 2024 19:19
naemono added a commit to naemono/docs that referenced this pull request Dec 18, 2024
Signed-off-by: Michael Montgomery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants