Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

Igor api key validation #1783

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

IgorGuz2000
Copy link
Contributor

@IgorGuz2000 IgorGuz2000 commented Nov 5, 2021

What does this PR do?

This PR test communication API keys are invalidated during unenrollment

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests (make unit-test), and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

#1192

@IgorGuz2000 IgorGuz2000 added area:test Anything related to the Test automation 8.0-candidate 7.16-candidate labels Nov 5, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 5, 2021

This pull request does not have a backport label. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 5, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 5, 2021

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-20T19:14:05.289+0000

  • Duration: 62 min 18 sec

  • Commit: b60ad26

Test stats 🧪

Test Results
Failed 5
Passed 219
Skipped 0
Total 224

Test errors 5

Expand to view the tests failures

Initializing / End-To-End Tests / fleet_amd64_fleet_mode_agent / Un-enrolling with revoke agent deactivates the agent – Fleet Mode Agent
    Expand to view the error details

     Step the agent Api key invalidated "true": The agent Api key invalidated is should be: true 
    

  • no stacktrace
Initializing / End-To-End Tests / kubernetes_autodiscover_elastic-agent / [empty] – TEST-x86_64-kubernetes-autodiscover-79e77bf2-2022-01-20-19:34:32.xml
  • no error details
  • Expand to view the stacktrace

     Test report file /var/lib/jenkins/workspace/PR-1783-28-6b7ada2c-9a89-4900-a9c1-664d262ec71e/outputs/18.219.45.37/TEST-x86_64-kubernetes-autodiscover-79e77bf2-2022-01-20-19:34:32.xml was length 0 
    

Initializing / End-To-End Tests / fleet_arm64_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent
    Expand to view the error details

     Step an agent is deployed to Fleet 
    

  • no stacktrace
Initializing / End-To-End Tests / fleet_sles15_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent
    Expand to view the error details

     Step an agent is deployed to Fleet 
    

  • no stacktrace
Initializing / End-To-End Tests / fleet_amd64_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent
    Expand to view the error details

     Step an agent is deployed to Fleet 
    

  • no stacktrace

Steps errors 2

Expand to view the steps failures

Shell Script
  • Took 21 min 12 sec . View more details here
  • Description: ssh -tt -o TCPKeepAlive=yes -o ServerAliveInterval=60 -o ServerAliveCountMax=10 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i /var/lib/jenkins/workspace/PR-1783-28-301e8c3e-560b-4392-87e5-60b0a23831fc/e2essh [email protected] -- 'sudo bash /home/admin/e2e-testing/.ci/scripts/functional-test.sh "fleet_mode_agent && ~@nightly && ~@skip:amd64" '
Archive the artifacts
  • Took 0 min 0 sec . View more details here
  • Description: [2022-01-20T19:54:48.168Z] Archiving artifacts script returned exit code 2

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors 5

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

  • Name: Initializing / End-To-End Tests / fleet_amd64_fleet_mode_agent / Un-enrolling with revoke agent deactivates the agent – Fleet Mode Agent
  • Name: Initializing / End-To-End Tests / kubernetes_autodiscover_elastic-agent / [empty] – TEST-x86_64-kubernetes-autodiscover-79e77bf2-2022-01-20-19:34:32.xml
  • Name: Initializing / End-To-End Tests / fleet_arm64_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent
  • Name: Initializing / End-To-End Tests / fleet_sles15_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent
  • Name: Initializing / End-To-End Tests / fleet_amd64_fleet_mode_agent / Deploying the agent with enroll and then run on rpm and deb – Fleet Mode Agent

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@IgorGuz2000 IgorGuz2000 added backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify labels Nov 5, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 5, 2021
internal/elasticsearch/client.go Outdated Show resolved Hide resolved
@adam-stokes
Copy link
Contributor

Just a note to hold off on merging this until #1740 is merged as this PR will need some cleanup on the feature file @IgorGuz2000 @mdelapenya

Copy link
Contributor

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments

I agree with @adam-stokes in delaying the merge until #1740 is merged (which will be very soon)

internal/kibana/agents.go Outdated Show resolved Hide resolved
@IgorGuz2000
Copy link
Contributor Author

Waiting for the #1740 to be merged

@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2021

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/master
git push upstream Igor_API_Key_validation

internal/elasticsearch/client.go Show resolved Hide resolved
internal/elasticsearch/client.go Outdated Show resolved Hide resolved
e2e/_suites/fleet/features/fleet_mode_agent.feature Outdated Show resolved Hide resolved
e2e/_suites/fleet/features/fleet_mode_agent.feature Outdated Show resolved Hide resolved
e2e/_suites/fleet/features/fleet_mode_agent.feature Outdated Show resolved Hide resolved
e2e/_suites/fleet/features/fleet_mode_agent.feature Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2022

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/main
git push upstream Igor_API_Key_validation

6 similar comments
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/main
git push upstream Igor_API_Key_validation

@mergify
Copy link
Contributor

mergify bot commented Apr 3, 2023

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/main
git push upstream Igor_API_Key_validation

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/main
git push upstream Igor_API_Key_validation

Copy link
Contributor

mergify bot commented Nov 1, 2023

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/main
git push upstream Igor_API_Key_validation

Copy link
Contributor

mergify bot commented Dec 14, 2023

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/main
git push upstream Igor_API_Key_validation

Copy link
Contributor

mergify bot commented Feb 20, 2024

This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b Igor_API_Key_validation upstream/Igor_API_Key_validation
git merge upstream/main
git push upstream Igor_API_Key_validation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
7.16-candidate 8.0-candidate area:test Anything related to the Test automation backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants