-
Notifications
You must be signed in to change notification settings - Fork 42
Igor api key validation #1783
base: main
Are you sure you want to change the base?
Igor api key validation #1783
Conversation
This pull request does not have a backport label. Could you fix it @IgorGuz2000? 🙏
|
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
|
Just a note to hold off on merging this until #1740 is merged as this PR will need some cleanup on the feature file @IgorGuz2000 @mdelapenya |
…or_API_Key_validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments
I agree with @adam-stokes in delaying the merge until #1740 is merged (which will be very soon)
Waiting for the #1740 to be merged |
This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
|
…dation # Conflicts: # e2e/_suites/fleet/features/fleet_mode_agent.feature
…or_API_Key_validation
This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
|
6 similar comments
This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
|
This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
|
This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
|
This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
|
This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
|
This pull request is now in conflict. Could you fix it @IgorGuz2000? 🙏
|
What does this PR do?
This PR test communication API keys are invalidated during unenrollment
Why is it important?
Checklist
make unit-test
), and they are passing locallymake notice
in the proper directory)Author's Checklist
How to test this PR locally
Related issues
#1192