-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Stage 1: Introducing new field in ECS Rule fields #2386
base: main
Are you sure you want to change the base?
Conversation
Updating the temaplate for RFC Stage 0 for adding 2 new rule fields: rule.tags and rule.remediation
Incorporating review comments.
… number in series.
Hi! We just realized that we haven't looked into this PR in a while. We're We're labeling this PR as Thank you for your contribution! |
Hi! We just realized that we haven't looked into this PR in a while. We're We're labeling this PR as Thank you for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smriti0321, could you also update https://github.com/elastic/ecs/blob/main/rfcs/text/0046-additional-rule-field.md to add some examples of usage, source data and the other criteria from here: https://elastic.github.io/ecs/stages.html
rfcs/text/0046/rule.yml
Outdated
fields: | ||
- name: remediation | ||
level: extended | ||
type: wildcard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would remediations usually be human-readable? In that case, using text
type could be better than wildcard: https://www.elastic.co/guide/en/elasticsearch/reference/current/keyword.html#wildcard-field-type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjwolf I have created a PR (#2448) for the suggested changes in https://github.com/elastic/ecs/blob/main/rfcs/text/0046-additional-rule-field.md. Please let me know if thats the right way.
As per comment (#2386 (review)) on Stage 1 of this RFC. Adding the usage, source data and scope of impact
make test
?make
and committed those changes?