Improve performance with efficient use of FieldMappingCache #389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change will improve the performance of
FieldMappingCache
Existing drawbacks:
field_mapping_cache
is initialized on every yield ofitertuples
anditerrows
repr()
orprint()
thefield_mapping_cache
is re initialized on every call.Now,
field_mapping_cache
is initialized once perquery_compiler
, that too only when ETL such asto_pandas()
oritertuples
oriterrows
orrepr()
orprint()
is done.Also, by default
scripted_fields
are considered as "object". Previously we were finding source field, then if it's not source field, an exception is raised and then its data type is assigned as "object".This also improves the readability of code.
@sethmlarson Take a look :)