Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tracing baai/bge-m3 #752

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Fix tracing baai/bge-m3 #752

merged 2 commits into from
Feb 12, 2025

Conversation

davidkyle
Copy link
Member

Fixes a kernel crash importing https://huggingface.co/BAAI/bge-m3 as described in #737

The required change is upgrading the version of transformers.

eland_import_hub_model \
  --url 'http://localhost:9200' \
  -u elastic-admin -p elastic-password \
  --hub-model-id 'baai/bge-m3' \
  --task-type text_embedding --insecure --max-model-input-length=8192

@davidkyle davidkyle mentioned this pull request Feb 6, 2025
Open
pquentin
pquentin approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@davidkyle davidkyle marked this pull request as ready for review February 12, 2025 09:27
@davidkyle davidkyle merged commit ee4d701 into elastic:main Feb 12, 2025
6 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
@davidkyle @github-actions
Upgrade transformers to 4.47 (#752)
c498f6f 
The upgrade fixes a crash tracing the baai/bge-m3 model

(cherry picked from commit ee4d701)
@github-actions github-actions bot mentioned this pull request Feb 12, 2025
Merged
pquentin pushed a commit that referenced this pull request Feb 12, 2025
@github-actions
Upgrade transformers to 4.47 (#752) (#759)
d50436b
@davidkyle davidkyle mentioned this pull request Feb 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
backport 8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidkyle @pquentin