Skip to content

Remove PGP signature verification skip for DEV builds #6028

Remove PGP signature verification skip for DEV builds

Remove PGP signature verification skip for DEV builds #6028

Triggered via pull request October 13, 2023 14:29
Status Failure
Total duration 4m 36s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

golangci-lint.yml

on: pull_request
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

12 errors and 6 warnings
lint (ubuntu-latest): internal/pkg/agent/application/upgrade/artifact/download/fs/verifier.go#L121
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
lint (ubuntu-latest): internal/pkg/agent/application/upgrade/artifact/download/http/common_test.go#L101
Error return value of `w.Write` is not checked (errcheck)
lint (ubuntu-latest): internal/pkg/agent/application/upgrade/artifact/download/http/common_test.go#L106
`reponse` is a misspelling of `response` (misspell)
lint (ubuntu-latest): internal/pkg/agent/application/upgrade/artifact/download/verifier.go#L119
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
lint (ubuntu-latest): testing/pgptest/pgp.go#L13
SA1019: "golang.org/x/crypto/openpgp" is deprecated: this package is unmaintained except for security fixes. New applications should consider a more focused, modern alternative to OpenPGP for their specific task. If you are required to interoperate with OpenPGP systems and need a maintained package, consider a community fork. See https://golang.org/issue/44226. (staticcheck)
lint (ubuntu-latest): testing/pgptest/pgp.go#L14
SA1019: "golang.org/x/crypto/openpgp/armor" is deprecated: this package is unmaintained except for security fixes. New applications should consider a more focused, modern alternative to OpenPGP for their specific task. If you are required to interoperate with OpenPGP systems and need a maintained package, consider a community fork. See https://golang.org/issue/44226. (staticcheck)
lint (ubuntu-latest): testing/pgptest/pgp.go#L24
ineffectual assignment to err (ineffassign)
lint (ubuntu-latest)
issues found
lint (windows-latest)
The job was canceled because "ubuntu-latest" failed.
lint (windows-latest)
The operation was canceled.
lint (macos-latest)
The job was canceled because "ubuntu-latest" failed.
lint (macos-latest)
The operation was canceled.
lint (ubuntu-latest)
Unexpected input(s) 'skip-go-installation', valid inputs are ['version', 'args', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-pkg-cache', 'skip-build-cache', 'install-mode']
lint (ubuntu-latest)
Unexpected input(s) 'skip-go-installation', valid inputs are ['version', 'args', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-pkg-cache', 'skip-build-cache', 'install-mode']
lint (windows-latest)
Unexpected input(s) 'skip-go-installation', valid inputs are ['version', 'args', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-pkg-cache', 'skip-build-cache', 'install-mode']
lint (windows-latest)
Unexpected input(s) 'skip-go-installation', valid inputs are ['version', 'args', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-pkg-cache', 'skip-build-cache', 'install-mode']
lint (macos-latest)
Unexpected input(s) 'skip-go-installation', valid inputs are ['version', 'args', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-pkg-cache', 'skip-build-cache', 'install-mode']
lint (macos-latest)
Unexpected input(s) 'skip-go-installation', valid inputs are ['version', 'args', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-pkg-cache', 'skip-build-cache', 'install-mode']