start stop server decision based only on metrics.enabled

elastic · Oct 11, 2023 · 08378a4 · 08378a4
1 parent fd06296
commit 08378a4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/internal/pkg/agent/application/monitoring/reload/reload.go b/internal/pkg/agent/application/monitoring/reload/reload.go
@@ -103,7 +103,7 @@ func (sr *ServerReloader) Reload(rawConfig *aConfig.Config) error {
 
 	sr.config = newConfig.Settings.MonitoringConfig
 
-	shouldRunMetrics := sr.config.Enabled && sr.config.MonitorMetrics
+	shouldRunMetrics := sr.config.Enabled
 	if shouldRunMetrics && !sr.isServerRunning {
 		sr.start()
 

diff --git a/internal/pkg/agent/application/monitoring/reload/reload_test.go b/internal/pkg/agent/application/monitoring/reload/reload_test.go
@@ -59,18 +59,18 @@ agent.monitoring.enabled: false
 			false, false, true,
 		},
 		{
-			"stop when running, monitoring.metrics disabled",
+			"do not stop when running, monitoring.metrics disabled",
 			true, true, true,
 			`
 agent.monitoring.metrics: false
 `,
-			false, false, true,
+			true, false, false,
 		},
 		{
 			"stop stopped server",
 			false, false, false,
 			`
-agent.monitoring.metrics: false
+agent.monitoring.enabled: false
 `,
 			false, false, false,
 		},