Skip to content

Commit

Permalink
Build only cloud image variant when it's requested
Browse files Browse the repository at this point in the history
Before this change we were building all possible Docker images to
produce the cloud image. Which is unnecessary and takes a long time.

Now only the `cloud` variant is built.
  • Loading branch information
rdner committed Dec 19, 2024
1 parent c7c5ba4 commit 1b352dd
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions magefile.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ const (
externalArtifacts = "EXTERNAL"
platformsEnv = "PLATFORMS"
packagesEnv = "PACKAGES"
dockerVariants = "DOCKER_VARIANTS"
configFile = "elastic-agent.yml"
agentDropPath = "AGENT_DROP_PATH"
checksumFilename = "checksum.yml"
Expand Down Expand Up @@ -782,9 +783,13 @@ func (Cloud) Image(ctx context.Context) {
dev := os.Getenv(devEnv)
defer os.Setenv(devEnv, dev)

variant := os.Getenv(dockerVariants)
defer os.Setenv(dockerVariants, variant)

os.Setenv(platformsEnv, "linux/amd64")
os.Setenv(packagesEnv, "docker")
os.Setenv(devEnv, "true")
os.Setenv(dockerVariants, "cloud")

if s, err := strconv.ParseBool(snapshot); err == nil && !s {
// only disable SNAPSHOT build when explicitely defined
Expand Down

0 comments on commit 1b352dd

Please sign in to comment.