-
Notifications
You must be signed in to change notification settings - Fork 148
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Uninstall finds and kills any running
elastic-agent watch
process (#…
…3384) * kill watcher on uninstall * Empty commit. * Fix killWatcher. * Empty commit. * Another fix for killWatcher. * Empty commit. * Catch ErrProcessDone. * Empty commit. * Empty commit * Add changelog fragment. * Make it work on Windows. * Change killWatcher to be in a loop. * Add loop to killWatcher. * Revert "Skip TestStandaloneUpgradeFailsStatus to fix failing integration tests again (#3391)" This reverts commit bf467e3. * Revert "Fix integration tests by waiting for the watcher to finish during upgrade tests (#3370)" This reverts commit 94764be. * Fix test. * Revert "Revert "Skip TestStandaloneUpgradeFailsStatus to fix failing integration tests again (#3391)"" This reverts commit 3b0f040. * Add progress tracking for uninstall like install. * Log when no watchers our found. * Improve uninstall. * Fix data race. (cherry picked from commit 7e86d24) # Conflicts: # internal/pkg/agent/cmd/install.go # internal/pkg/agent/install/install.go # internal/pkg/agent/install/progress.go # internal/pkg/agent/install/progress_test.go
- Loading branch information
1 parent
a3f132e
commit 324f813
Showing
9 changed files
with
660 additions
and
78 deletions.
There are no files selected for viewing
32 changes: 32 additions & 0 deletions
32
changelog/fragments/1694187216-Uninstall-finds-and-kills-any-running-watcher-process.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# Kind can be one of: | ||
# - breaking-change: a change to previously-documented behavior | ||
# - deprecation: functionality that is being removed in a later release | ||
# - bug-fix: fixes a problem in a previous version | ||
# - enhancement: extends functionality but does not break or fix existing behavior | ||
# - feature: new functionality | ||
# - known-issue: problems that we are aware of in a given version | ||
# - security: impacts on the security of a product or a user’s deployment. | ||
# - upgrade: important information for someone upgrading from a prior version | ||
# - other: does not fit into any of the other categories | ||
kind: bug-fix | ||
|
||
# Change summary; a 80ish characters long description of the change. | ||
summary: Uninstall finds and kills any running watcher process | ||
|
||
# Long description; in case the summary is not enough to describe the change | ||
# this field accommodate a description without length limits. | ||
# NOTE: This field will be rendered only for breaking-change and known-issue kinds at the moment. | ||
#description: | ||
|
||
# Affected component; usually one of "elastic-agent", "fleet-server", "filebeat", "metricbeat", "auditbeat", "all", etc. | ||
component: | ||
|
||
# PR URL; optional; the PR number that added the changeset. | ||
# If not present is automatically filled by the tooling finding the PR where this changelog fragment has been added. | ||
# NOTE: the tooling supports backports, so it's able to fill the original PR number instead of the backport PR number. | ||
# Please provide it if you are adding a fragment for a different PR. | ||
pr: https://github.com/elastic/elastic-agent/pull/3384 | ||
|
||
# Issue URL; optional; the GitHub issue related to this changeset (either closes or is part of). | ||
# If not present is automatically filled by the tooling with the issue linked to the PR number. | ||
issue: https://github.com/elastic/elastic-agent/issues/3371 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.